From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3DE5C43387 for ; Mon, 31 Dec 2018 18:15:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B683320B1F for ; Mon, 31 Dec 2018 18:15:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727681AbeLaSPE (ORCPT ); Mon, 31 Dec 2018 13:15:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:58052 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726722AbeLaSPE (ORCPT ); Mon, 31 Dec 2018 13:15:04 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 67920ACC3; Mon, 31 Dec 2018 18:15:02 +0000 (UTC) Date: Mon, 31 Dec 2018 19:15:02 +0100 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Cc: Takashi Iwai , Linus Torvalds , Ingo Molnar , Mark Brown , Liam Girdwood , Linux Kernel Mailing List Subject: Re: [GIT PULL] sound updates for 4.21 In-Reply-To: References: <20181228124303.GA16558@gmail.com> <82bb7f60-c3c2-4715-a0a0-f1f2a8b14c74@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Dec 2018 11:24:41 +0100, Pierre-Louis Bossart wrote: > > > On 12/31/18 2:11 AM, Takashi Iwai wrote: > > On Mon, 31 Dec 2018 00:17:58 +0100, > > Pierre-Louis Bossart wrote: > >>> BTW, one thing I'd really like to avoid is to rearrange the probe > >>> procedure of the legacy HDA driver (so that we can get codec_mask > >>> during pci probe() call). The async probe is the result of the many > >>> struggles with the various and complex configurations. Moving the > >>> codec probe to the beginning isn't trivial and quite risky to break > >>> something else. > >> Agree, mucking with the probe isn't something we should look into, > >> especially with this Skylake driver being eventually deprecated once > >> SOF is at feature parity. This set of autodetection patches for 4.21 > >> was really targeting CFL/WHL+ devices, where the DSP usage is > >> mandatory when directly-attached digital microphones are used. For > >> Skylake and kabylake using the legacy by default is just fine. > > OK, then how about applying the PCI class check only for such ones > > like the patch below? The macro isn't sexy and can be replaced with > > another way, but you have an idea. > > The two patches which added the PCI class checks were supposed to be a > simple bullet-proof way of detecting the DSP presence and solving a > problem of coexistence between two drivers. At this point if we start > adding quirks and still have unclear issues with HDMI support which > isn't different for CFL+, it may be wiser to revert them to let the > 4.21 merge window progress? It's frustrating but I'd rather solve this > problem the right way than with multiple iterations rushed because of > the merge window timing. Fair enough, let's revert them for now. I'm going to submit the revert patch. thanks, Takashi