From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764341AbdKRJZj (ORCPT ); Sat, 18 Nov 2017 04:25:39 -0500 Received: from mx2.suse.de ([195.135.220.15]:58328 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754068AbdKRJZc (ORCPT ); Sat, 18 Nov 2017 04:25:32 -0500 Date: Sat, 18 Nov 2017 10:25:28 +0100 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, broonie@kernel.org, torvalds@linux-foundation.org, vinod.koul@intel.com, liam.r.girdwood@linux.intel.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/7] Fix Intel audio Kconfig issues In-Reply-To: <20171118000202.22302-1-pierre-louis.bossart@linux.intel.com> References: <20171118000202.22302-1-pierre-louis.bossart@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Nov 2017 01:01:55 +0100, Pierre-Louis Bossart wrote: > > At the risk of being scolded for the third time in two days by > Linux overlords (no hard feelings), here's an attempt to clean > things up. > > The first patch *should* implement what Linus, Takashi and Mark > tried to explain by email. There should be no functionality change > and could be merged if deemed ok. > > The rest of the patch series does a more in-depth cleanup and should not > be merged without more testing (hence the RFC). > > The 4th patch is really the most important one, there were nested > configs which made no sense to me. I don't know the history which led > to such complicated stuff but simpler is better. > > The last 3 patches are just clean-ups of the machine driver configs, > for some reason there is no consistency in the settings so I tried to > apply common sense. There might be additional cleanup needed since I > don't really get why we need references to LPSS or DESIGNWARE for things > which are not visible to a machine driver, we should only depend on IC2 or > SPI in my opinion - depending on what the control interface is. > > I tried to keep things to a minimum in each patch to make the reviews > easier, if people want them squashed that's fine by me. > > I'll do some more testing on my side but I could use feedback. Thanks! FYI, I've put these to a test branch, test/asoc-intel-kconfig, so that 0day bot can catch issues. Let's see. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [RFC PATCH 0/7] Fix Intel audio Kconfig issues Date: Sat, 18 Nov 2017 10:25:28 +0100 Message-ID: References: <20171118000202.22302-1-pierre-louis.bossart@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id CC87E266B02 for ; Sat, 18 Nov 2017 10:25:31 +0100 (CET) In-Reply-To: <20171118000202.22302-1-pierre-louis.bossart@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, arnd@arndb.de, vinod.koul@intel.com, linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com, broonie@kernel.org, andriy.shevchenko@linux.intel.com, torvalds@linux-foundation.org List-Id: alsa-devel@alsa-project.org On Sat, 18 Nov 2017 01:01:55 +0100, Pierre-Louis Bossart wrote: > > At the risk of being scolded for the third time in two days by > Linux overlords (no hard feelings), here's an attempt to clean > things up. > > The first patch *should* implement what Linus, Takashi and Mark > tried to explain by email. There should be no functionality change > and could be merged if deemed ok. > > The rest of the patch series does a more in-depth cleanup and should not > be merged without more testing (hence the RFC). > > The 4th patch is really the most important one, there were nested > configs which made no sense to me. I don't know the history which led > to such complicated stuff but simpler is better. > > The last 3 patches are just clean-ups of the machine driver configs, > for some reason there is no consistency in the settings so I tried to > apply common sense. There might be additional cleanup needed since I > don't really get why we need references to LPSS or DESIGNWARE for things > which are not visible to a machine driver, we should only depend on IC2 or > SPI in my opinion - depending on what the control interface is. > > I tried to keep things to a minimum in each patch to make the reviews > easier, if people want them squashed that's fine by me. > > I'll do some more testing on my side but I could use feedback. Thanks! FYI, I've put these to a test branch, test/asoc-intel-kconfig, so that 0day bot can catch issues. Let's see. thanks, Takashi