From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: onkel@paraair.de, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/5] ALSA: usb-audio: purge needless variable length array
Date: Mon, 20 Feb 2017 22:04:44 +0100 [thread overview]
Message-ID: <s5ho9xwpo9f.wl-tiwai@suse.de> (raw)
In-Reply-To: <s5hshn8pout.wl-tiwai@suse.de> <20170220200921.824-3-o-takashi@sakamocchi.jp>
On Mon, 20 Feb 2017 21:51:54 +0100,
Takashi Iwai wrote:
>
> On Mon, 20 Feb 2017 21:09:18 +0100,
> Takashi Sakamoto wrote:
> >
> > Variable length array is used in 'snd_us16x08_meter_get()', while there
> > is logically no need. It's better to purge it because variable length array
> > has overhead for stack handling.
> >
> > This commit replaces the array with static length. Sparse generated below
> > warning.
> >
> > sound/usb/mixer_us16x08.c:714:18: warning: Variable length array is used.
> >
> > Fixes: d2bb390a2081 ("ALSA: usb-audio: Tascam US-16x08 DSP mixer quirk")
> > Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
>
> Applied, thanks.
Eh, no, this patch is buggy. Scratched.
> @@ -740,7 +740,8 @@ static int snd_us16x08_meter_get(struct snd_kcontrol *kcontrol,
> case 3:
> memcpy(tmp, mix_init_msg2, sizeof(mix_init_msg2));
> tmp[2] = snd_get_meter_comp_index(store);
> - snd_us16x08_send_urb(chip, tmp, 10);
> + snd_us16x08_send_urb(chip, (char *)mix_init_msg2,
> + sizeof(mix_init_msg2));
Here you overlooked that tmp[2] is dynamically changed.
Takashi
next prev parent reply other threads:[~2017-02-20 21:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 20:09 [PATCH 0/5] ALSA: usb-audio: fixes for quirks of Tascam US-16x08 Takashi Sakamoto
2017-02-20 20:09 ` [PATCH 1/5] ALSA: usb-audio: localize one-referrer variable Takashi Sakamoto
2017-02-20 20:51 ` Takashi Iwai
2017-02-20 20:09 ` [PATCH 2/5] ALSA: usb-audio: purge needless variable length array Takashi Sakamoto
2017-02-20 20:51 ` Takashi Iwai
2017-02-20 21:04 ` Takashi Iwai [this message]
2017-02-21 2:23 ` Takashi Sakamoto
2017-02-20 20:09 ` [PATCH 3/5] ALSA: usb-audio: localize function without external linkage Takashi Sakamoto
2017-02-20 20:52 ` Takashi Iwai
2017-02-20 20:09 ` [PATCH 4/5] ALSA: usb-audio: deallocate memory objects in error path Takashi Sakamoto
2017-02-20 20:49 ` Takashi Iwai
2017-02-21 2:32 ` Takashi Sakamoto
2017-02-21 22:45 ` Takashi Sakamoto
2017-02-21 22:59 ` Takashi Sakamoto
2017-02-22 1:42 ` Takashi Sakamoto
2017-02-22 7:44 ` Takashi Iwai
2017-02-22 7:46 ` Takashi Iwai
2017-02-22 13:37 ` Takashi Sakamoto
2017-02-22 14:05 ` Takashi Iwai
2017-02-22 13:20 ` Takashi Sakamoto
2017-02-20 20:09 ` [PATCH 5/5] ALSA: usb-audio: fix msleep timeout due to minimum resolution of task scheduling Takashi Sakamoto
2017-02-20 20:51 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ho9xwpo9f.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=o-takashi@sakamocchi.jp \
--cc=onkel@paraair.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.