From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Intel HDA / ca0132: support for Alienware 15 Creative Sound Core3D-EX Date: Wed, 29 Apr 2015 15:40:03 +0200 Message-ID: References: <553AE4CF.3070805@gmx.com> <553E7B34.2080501@gmx.com> <553EB55D.4060701@gmx.com> <55400DF4.2080309@gmx.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 61DC8260606 for ; Wed, 29 Apr 2015 15:40:03 +0200 (CEST) In-Reply-To: <55400DF4.2080309@gmx.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Gabriele Martino Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Wed, 29 Apr 2015 00:47:16 +0200, Gabriele Martino wrote: > > @@ -4653,6 +4667,7 @@ > return -ENOMEM; > codec->spec = spec; > spec->codec = codec; > + spec->quirk = snd_pci_quirk_lookup(codec->bus->pci, ca0132_quirks); > > spec->dsp_state = DSP_DOWNLOAD_INIT; > spec->num_mixers = 1; > @@ -4670,6 +4685,12 @@ > > ca0132_config(codec); > > + /* Apply detected quirks */ > + if (spec->quirk->value == QUIRK_ALIENWARE) { Add a NULL check. Or, rather just record only quirk->value as spec->quirk. quirk = snd_pci_quirk_lookup(pci, quirks); if (quirk) spec->quirk = quirk->value; .... if (spec->quirk == QUIRK_ALIENWARE) .... Takashi