All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: alsa-devel@alsa-project.org, Dylan Reid <dgreid@chromium.org>
Subject: Re: [PATCH 1/3] ALSA: hda - Remove dependency on bus->pci in hda_beep.c
Date: Wed, 19 Feb 2014 09:33:07 +0100	[thread overview]
Message-ID: <s5hob23y01o.wl%tiwai@suse.de> (raw)
In-Reply-To: <5303A0A3.6050206@wwwdotorg.org>

At Tue, 18 Feb 2014 11:04:19 -0700,
Stephen Warren wrote:
> 
> On 02/15/2014 02:22 AM, Takashi Iwai wrote:
> > At Sat, 15 Feb 2014 10:17:33 +0100,
> > Takashi Iwai wrote:
> >>
> >> The default parent device can be obtained directly via card object, so
> >> we don't need to rely on pci->dev.parent.  Since there is no access to
> >> pci_dev, we can reduce the inclusion of linux/pci.h, too.
> >>
> >> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > 
> > I forgot the cover page: these tree patches are trivial cleanups of
> > hda-codec drivers (not the controller) to work without PCI device
> > assignment. The idea was triggered by Dylan's question.
> 
> The series seems fine to me, so briefly,
> Reviewed-by: Stephen Warren <swarren@nvidia.com>

Thanks.  Any chance to work on / submit other changes for Tegra
HD-audio support?

As already mentioned, I think a cleaner way would be to write
hda_platform.c instead of hacking hda_intel.c with ifdefs.
Some code in hda_intel.c (e.g. bus ops and PCM callbacks) can be moved
out, either as a new helper module or just merging into snd-hda-codec
helper module, so that they can be used by both hda_intel.c and
hda_platform.c.

Ideally, we may rename hda_intel.c with hda_pci.c, but I'm afraid this
would bring too many regressions for module options.


Takashi

  parent reply	other threads:[~2014-02-19  8:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-15  9:17 Takashi Iwai
2014-02-15  9:17 ` [PATCH 2/3] ALSA: hda/realtek - Allow NULL bus->pci Takashi Iwai
2014-02-15  9:17 ` [PATCH 3/3] ALSA: hda - Remove superfluous inclusion of linux/pci.h Takashi Iwai
2014-02-15  9:22 ` [PATCH 1/3] ALSA: hda - Remove dependency on bus->pci in hda_beep.c Takashi Iwai
2014-02-18 18:04   ` Stephen Warren
2014-02-18 18:20     ` Dylan Reid
2014-02-19  8:33     ` Takashi Iwai [this message]
2014-02-19 15:16       ` Dylan Reid
2014-02-27 12:03         ` Takashi Iwai
2014-02-27 16:44           ` Dylan Reid
2014-02-27 16:57             ` Takashi Iwai
2014-02-27 17:32               ` Dylan Reid
2014-02-27 20:10                 ` Takashi Iwai
2014-02-27 20:41                   ` Dylan Reid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hob23y01o.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dgreid@chromium.org \
    --cc=swarren@wwwdotorg.org \
    --subject='Re: [PATCH 1/3] ALSA: hda - Remove dependency on bus->pci in hda_beep.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.