From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757997AbZELHX4 (ORCPT ); Tue, 12 May 2009 03:23:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754363AbZELHXr (ORCPT ); Tue, 12 May 2009 03:23:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59897 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752646AbZELHXq (ORCPT ); Tue, 12 May 2009 03:23:46 -0400 Date: Tue, 12 May 2009 09:23:47 +0200 Message-ID: From: Takashi Iwai To: Greg KH Cc: Roel Kluin , johannes@sipsolutions.net, linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org, lkml Subject: Re: [alsa-devel] [PATCH] aoa: remove driver_data direct access of struct device In-Reply-To: <20090512065743.GA25267@suse.de> References: <4A08828B.7090106@gmail.com> <20090512065743.GA25267@suse.de> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 11 May 2009 23:57:43 -0700, Greg KH wrote: > > On Tue, May 12, 2009 at 08:40:05AM +0200, Takashi Iwai wrote: > > At Mon, 11 May 2009 21:54:51 +0200, > > Roel Kluin wrote: > > > > > > To avoid direct access to the driver_data pointer in struct device, the > > > functions dev_get_drvdata() and dev_set_drvdata() should be used. > > > > > > Signed-off-by: Roel Kluin > > > > The same fix has been already in Greg's tree (and thus in linux-next). > > > > Greg, is it OK that I take over your patch to sound git tree? > > Yes, please do, no objection from me at all. OK, will do. BTW, should it be pushed to 2.6.30? If "the near future" you mentioned in the patch means 2.6.31, it'll be better to merge that fix now. Otherwise, I'm going to apply the patch as a 2.6.31 material. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] aoa: remove driver_data direct access of struct device Date: Tue, 12 May 2009 09:23:47 +0200 Message-ID: References: <4A08828B.7090106@gmail.com> <20090512065743.GA25267@suse.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 7D6A8246D3 for ; Tue, 12 May 2009 09:23:47 +0200 (CEST) In-Reply-To: <20090512065743.GA25267@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Greg KH Cc: linuxppc-dev@ozlabs.org, johannes@sipsolutions.net, Roel Kluin , alsa-devel@alsa-project.org, lkml List-Id: alsa-devel@alsa-project.org At Mon, 11 May 2009 23:57:43 -0700, Greg KH wrote: > > On Tue, May 12, 2009 at 08:40:05AM +0200, Takashi Iwai wrote: > > At Mon, 11 May 2009 21:54:51 +0200, > > Roel Kluin wrote: > > > > > > To avoid direct access to the driver_data pointer in struct device, the > > > functions dev_get_drvdata() and dev_set_drvdata() should be used. > > > > > > Signed-off-by: Roel Kluin > > > > The same fix has been already in Greg's tree (and thus in linux-next). > > > > Greg, is it OK that I take over your patch to sound git tree? > > Yes, please do, no objection from me at all. OK, will do. BTW, should it be pushed to 2.6.30? If "the near future" you mentioned in the patch means 2.6.31, it'll be better to merge that fix now. Otherwise, I'm going to apply the patch as a 2.6.31 material. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx2.suse.de", Issuer "CAcert Class 3 Root" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id CAEC5DDD1B for ; Tue, 12 May 2009 17:23:52 +1000 (EST) Date: Tue, 12 May 2009 09:23:47 +0200 Message-ID: From: Takashi Iwai To: Greg KH Subject: Re: [alsa-devel] [PATCH] aoa: remove driver_data direct access of struct device In-Reply-To: <20090512065743.GA25267@suse.de> References: <4A08828B.7090106@gmail.com> <20090512065743.GA25267@suse.de> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linuxppc-dev@ozlabs.org, johannes@sipsolutions.net, Roel Kluin , alsa-devel@alsa-project.org, lkml List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , At Mon, 11 May 2009 23:57:43 -0700, Greg KH wrote: > > On Tue, May 12, 2009 at 08:40:05AM +0200, Takashi Iwai wrote: > > At Mon, 11 May 2009 21:54:51 +0200, > > Roel Kluin wrote: > > > > > > To avoid direct access to the driver_data pointer in struct device, the > > > functions dev_get_drvdata() and dev_set_drvdata() should be used. > > > > > > Signed-off-by: Roel Kluin > > > > The same fix has been already in Greg's tree (and thus in linux-next). > > > > Greg, is it OK that I take over your patch to sound git tree? > > Yes, please do, no objection from me at all. OK, will do. BTW, should it be pushed to 2.6.30? If "the near future" you mentioned in the patch means 2.6.31, it'll be better to merge that fix now. Otherwise, I'm going to apply the patch as a 2.6.31 material. thanks, Takashi