From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D61C433EF for ; Tue, 28 Sep 2021 06:12:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3574061058 for ; Tue, 28 Sep 2021 06:12:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3574061058 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E58F2168F; Tue, 28 Sep 2021 08:11:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E58F2168F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1632809521; bh=Pvoue6xFOvC3MfaXnDqLdDzy9t4DWnb+GUh9TRndNqc=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HnRXhd/p7n8Mv1kJgQYHb+A4MNOnsLliSylmu28Ccseb+tJX8J8eqPnammoVcD+sI 9sloEA3lI30R6lpI775GgpkURPlL1iEjFGM/rJdMqYH+lBsWtIT8B5e2n3sf//88XZ SNyUr08RyC+TjxMA4QOmYHvdt4Jg6GT8QKsiu+P4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 47BADF8032C; Tue, 28 Sep 2021 08:11:10 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A62DDF804AD; Tue, 28 Sep 2021 08:11:08 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A55CCF800DE for ; Tue, 28 Sep 2021 08:11:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A55CCF800DE Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="1Hx2fsst"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="vgBO3rzI" Received: from relay1.suse.de (relay1.suse.de [149.44.160.133]) by smtp-out1.suse.de (Postfix) with ESMTP id BC7BB22212; Tue, 28 Sep 2021 06:10:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1632809459; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1VxJULCAkXo/zkFHIm4mcuZhVch/z+Y2yH1ju/bkrMs=; b=1Hx2fsstp0UBPI8gO+tQzdKPyF144CV72UEHYqKD3uHVi7QW7d/IsUT7PDm2NT0nRMAPOb +Vk7GwAQ6evJVtdSQQLcKNXs/7c8sKZ+yEr8Xd2rs8ZUuip45B8Hkw6ExsYPGUI2h4IuEp g8/sQtyy1mkKqtD5kwlZ+rjKCWtgL28= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1632809459; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1VxJULCAkXo/zkFHIm4mcuZhVch/z+Y2yH1ju/bkrMs=; b=vgBO3rzIsVcU8i/fZVy9wmm4hWc/PWt9eW6UblbtWcm9jzqGD/noJTIpkJl9WPN6yMXLzV PnQO7zNmlPXU00BQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay1.suse.de (Postfix) with ESMTP id B56AA25D93; Tue, 28 Sep 2021 06:10:59 +0000 (UTC) Date: Tue, 28 Sep 2021 08:10:59 +0200 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Subject: Re: [RFC PATCH 2/4] ALSA: hda: hdac_stream: reset assigned_key in stream_release() In-Reply-To: <20210924192417.169243-3-pierre-louis.bossart@linux.intel.com> References: <20210924192417.169243-1-pierre-louis.bossart@linux.intel.com> <20210924192417.169243-3-pierre-louis.bossart@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Cezary Rojewski , alsa-devel@alsa-project.org, broonie@kernel.org, vkoul@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 24 Sep 2021 21:24:15 +0200, Pierre-Louis Bossart wrote: > > The 'assigned_key' field is set in assign() and never reset. For > symmetry set to zero in release(). This is intentional behavior. We want to assign to the same stream persistently unless it has to be reassigned to another. thanks, Takashi > > Signed-off-by: Pierre-Louis Bossart > --- > sound/hda/hdac_stream.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/hda/hdac_stream.c b/sound/hda/hdac_stream.c > index 9867555883c3..3ae23c50d505 100644 > --- a/sound/hda/hdac_stream.c > +++ b/sound/hda/hdac_stream.c > @@ -333,6 +333,7 @@ void snd_hdac_stream_release(struct hdac_stream *azx_dev) > spin_lock_irq(&bus->reg_lock); > azx_dev->opened = 0; > azx_dev->running = 0; > + azx_dev->assigned_key = 0; > azx_dev->substream = NULL; > spin_unlock_irq(&bus->reg_lock); > } > -- > 2.25.1 >