From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5E8EC2B9F8 for ; Tue, 25 May 2021 09:27:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7EAA61360 for ; Tue, 25 May 2021 09:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232475AbhEYJ3K (ORCPT ); Tue, 25 May 2021 05:29:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:54264 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232530AbhEYJ3F (ORCPT ); Tue, 25 May 2021 05:29:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621934855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQlYaaBAybmBVUAGlRLhcaeBlT3WUi4ttbQdnsQvkkc=; b=Z5IFxkkqBLurgeYrmix32ALtnLT8lESgjZwzcw8pSHjE1t+wVxLtaTAnEY84Yd8srphYjb DXNkN7/1wWh/OZndYtoGp7JzrnNS1qEB+GU+VdSDfY2HXaraGUWGpzKArrrq7N0sgT1kWp smaoRynoJTMxNcR8pCYrm/mLTnIusIg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621934855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQlYaaBAybmBVUAGlRLhcaeBlT3WUi4ttbQdnsQvkkc=; b=w5nx12E3s3jTBrzYYio/pTtjlRrpP2if1P01HcjOBFvnQvkKvT9WoFa60nHBjeZKOVFGfl MfRFxF961C/czXCg== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CF558AECB; Tue, 25 May 2021 09:27:34 +0000 (UTC) Date: Tue, 25 May 2021 11:27:34 +0200 Message-ID: From: Takashi Iwai To: Maxime Ripard Cc: Mark Brown , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Dom Cobley , Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, Eric Anholt , Rob Herring , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Daniel Vetter , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec In-Reply-To: <20210525092353.mvqdv4bi4i4rkqsu@gilmour> References: <20210507140334.204865-1-maxime@cerno.tech> <20210524133904.kgkh6xd3m5c2j3xa@gilmour> <20210525092353.mvqdv4bi4i4rkqsu@gilmour> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 May 2021 11:23:53 +0200, Maxime Ripard wrote: > > Hi Takashi, > > On Tue, May 25, 2021 at 10:35:14AM +0200, Takashi Iwai wrote: > > On Mon, 24 May 2021 15:39:04 +0200, > > Maxime Ripard wrote: > > > > > > Hi, > > > > > > On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > > > > Hi, > > > > > > > > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place, > > > > it's missing a few controls to be able to provide HBR passthrough. This series > > > > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > > > > controller driver. > > > > > > > > One thing that felt a bit weird is that even though > > > > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-driver.html#iec958-s-pdif > > > > mentions that the iec958 mask control should be a mixer control and the > > > > default control should be a PCM one, it feels a bit weird to have two different > > > > control type for two controls so similar, and other drivers are pretty > > > > inconsistent with this. Should we update the documentation? > > > > > > Any comments on this series? > > > > A patch for updating the documentation is welcome. > > Currently, as de facto standard, we allow both MIXER and PCM ifaces > > for all IEC958-related controls, and it's unlikely that we would > > change that in future. > > Ok, I'll write a patch for the documentation make it clearer then :) > > Do we want to make sure that all the iec958 controls are on the same > iface, or is it also left to the driver (or should we just leave the > existing drivers as is but encourage a consistent use in the future)? I'd leave the existing drivers as-is. Changing the iface is basically an incompatible change, and although most of applications and alsa-lib should look at both ifaces, there can be any surprise by that change. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92D36C4707F for ; Tue, 25 May 2021 09:28:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD15D61417 for ; Tue, 25 May 2021 09:28:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD15D61417 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 118D61729; Tue, 25 May 2021 11:27:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 118D61729 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621934915; bh=2dconjSSYW3+zJuQduUoaIpK4mSNiPGKfwOwwXz7yss=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Tf8EGZPWSfwk/ke3ajyUI6qLtzBww0JOA57QetNO+B9GzeukbIWReqcUE9mVx+Fxz pbkW6UxqXbT4lVf/V3omJIIyZRyvs7zDF78Negn/OhBycMOxyciFaY08KhrUSPfthJ SYVmpizJAqjn5eadVPHjOYr4Xsu4D0ZRsC95SiiY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8187EF80137; Tue, 25 May 2021 11:27:44 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 72DA4F801EB; Tue, 25 May 2021 11:27:42 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 73446F80137 for ; Tue, 25 May 2021 11:27:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 73446F80137 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Z5IFxkkq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="w5nx12E3" X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621934855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQlYaaBAybmBVUAGlRLhcaeBlT3WUi4ttbQdnsQvkkc=; b=Z5IFxkkqBLurgeYrmix32ALtnLT8lESgjZwzcw8pSHjE1t+wVxLtaTAnEY84Yd8srphYjb DXNkN7/1wWh/OZndYtoGp7JzrnNS1qEB+GU+VdSDfY2HXaraGUWGpzKArrrq7N0sgT1kWp smaoRynoJTMxNcR8pCYrm/mLTnIusIg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621934855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQlYaaBAybmBVUAGlRLhcaeBlT3WUi4ttbQdnsQvkkc=; b=w5nx12E3s3jTBrzYYio/pTtjlRrpP2if1P01HcjOBFvnQvkKvT9WoFa60nHBjeZKOVFGfl MfRFxF961C/czXCg== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CF558AECB; Tue, 25 May 2021 09:27:34 +0000 (UTC) Date: Tue, 25 May 2021 11:27:34 +0200 Message-ID: From: Takashi Iwai To: Maxime Ripard Subject: Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec In-Reply-To: <20210525092353.mvqdv4bi4i4rkqsu@gilmour> References: <20210507140334.204865-1-maxime@cerno.tech> <20210524133904.kgkh6xd3m5c2j3xa@gilmour> <20210525092353.mvqdv4bi4i4rkqsu@gilmour> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Tim Gover , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Eric Anholt , Daniel Vetter , Phil Elwell , Dave Stevenson , Takashi Iwai , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, Nicolas Saenz Julienne , Daniel Vetter , Maarten Lankhorst , Mark Brown , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dom Cobley , Liam Girdwood , Rob Herring , Thomas Zimmermann X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 25 May 2021 11:23:53 +0200, Maxime Ripard wrote: > > Hi Takashi, > > On Tue, May 25, 2021 at 10:35:14AM +0200, Takashi Iwai wrote: > > On Mon, 24 May 2021 15:39:04 +0200, > > Maxime Ripard wrote: > > > > > > Hi, > > > > > > On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > > > > Hi, > > > > > > > > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place, > > > > it's missing a few controls to be able to provide HBR passthrough. This series > > > > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > > > > controller driver. > > > > > > > > One thing that felt a bit weird is that even though > > > > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-driver.html#iec958-s-pdif > > > > mentions that the iec958 mask control should be a mixer control and the > > > > default control should be a PCM one, it feels a bit weird to have two different > > > > control type for two controls so similar, and other drivers are pretty > > > > inconsistent with this. Should we update the documentation? > > > > > > Any comments on this series? > > > > A patch for updating the documentation is welcome. > > Currently, as de facto standard, we allow both MIXER and PCM ifaces > > for all IEC958-related controls, and it's unlikely that we would > > change that in future. > > Ok, I'll write a patch for the documentation make it clearer then :) > > Do we want to make sure that all the iec958 controls are on the same > iface, or is it also left to the driver (or should we just leave the > existing drivers as is but encourage a consistent use in the future)? I'd leave the existing drivers as-is. Changing the iface is basically an incompatible change, and although most of applications and alsa-lib should look at both ifaces, there can be any surprise by that change. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41168C2B9F8 for ; Tue, 25 May 2021 09:29:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 090B561408 for ; Tue, 25 May 2021 09:29:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 090B561408 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AVD9qX9IfG//W4wrj+b9eXe+XxwMPb/LW+u6YXNV8v0=; b=nJhTGAA8VWtAwd 7arbJuAAwkkufXOQ+eT/kNrw7EASXGOjymQHgCoF6UpeNkaYCwU16ajw05m5bPSwhrf1gX6N7Tbwu PgLWv3oh9H2ITt98S7W3ZrHyrPIEPbIzfIvtzYv9dakj28VTkTT57C8HYogm8iTxh3UoiauyRPBMO 2q0p/011d+tGZQjYlXFcAtc/CJtjtg7b8jqpaJFTdxORajvukKH78opiJLwpBpwXhW9iH4xtPjmdc adyVSaoVCyALZQujpHtFElkkySQg9FH7DmuEtkyD67tj+wy7Nd9yoqX5j9GOJ3UXHSmUnUFdihoto KnHJEHqASyF3K3M3uVAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llTLk-004MbD-IR; Tue, 25 May 2021 09:27:45 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llTLe-004MZA-Ca; Tue, 25 May 2021 09:27:40 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621934855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQlYaaBAybmBVUAGlRLhcaeBlT3WUi4ttbQdnsQvkkc=; b=Z5IFxkkqBLurgeYrmix32ALtnLT8lESgjZwzcw8pSHjE1t+wVxLtaTAnEY84Yd8srphYjb DXNkN7/1wWh/OZndYtoGp7JzrnNS1qEB+GU+VdSDfY2HXaraGUWGpzKArrrq7N0sgT1kWp smaoRynoJTMxNcR8pCYrm/mLTnIusIg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621934855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQlYaaBAybmBVUAGlRLhcaeBlT3WUi4ttbQdnsQvkkc=; b=w5nx12E3s3jTBrzYYio/pTtjlRrpP2if1P01HcjOBFvnQvkKvT9WoFa60nHBjeZKOVFGfl MfRFxF961C/czXCg== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CF558AECB; Tue, 25 May 2021 09:27:34 +0000 (UTC) Date: Tue, 25 May 2021 11:27:34 +0200 Message-ID: From: Takashi Iwai To: Maxime Ripard Cc: Mark Brown , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Dom Cobley , Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, Eric Anholt , Rob Herring , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Daniel Vetter , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec In-Reply-To: <20210525092353.mvqdv4bi4i4rkqsu@gilmour> References: <20210507140334.204865-1-maxime@cerno.tech> <20210524133904.kgkh6xd3m5c2j3xa@gilmour> <20210525092353.mvqdv4bi4i4rkqsu@gilmour> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_022738_755603_CB011E7C X-CRM114-Status: GOOD ( 33.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 25 May 2021 11:23:53 +0200, Maxime Ripard wrote: > > Hi Takashi, > > On Tue, May 25, 2021 at 10:35:14AM +0200, Takashi Iwai wrote: > > On Mon, 24 May 2021 15:39:04 +0200, > > Maxime Ripard wrote: > > > > > > Hi, > > > > > > On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > > > > Hi, > > > > > > > > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place, > > > > it's missing a few controls to be able to provide HBR passthrough. This series > > > > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > > > > controller driver. > > > > > > > > One thing that felt a bit weird is that even though > > > > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-driver.html#iec958-s-pdif > > > > mentions that the iec958 mask control should be a mixer control and the > > > > default control should be a PCM one, it feels a bit weird to have two different > > > > control type for two controls so similar, and other drivers are pretty > > > > inconsistent with this. Should we update the documentation? > > > > > > Any comments on this series? > > > > A patch for updating the documentation is welcome. > > Currently, as de facto standard, we allow both MIXER and PCM ifaces > > for all IEC958-related controls, and it's unlikely that we would > > change that in future. > > Ok, I'll write a patch for the documentation make it clearer then :) > > Do we want to make sure that all the iec958 controls are on the same > iface, or is it also left to the driver (or should we just leave the > existing drivers as is but encourage a consistent use in the future)? I'd leave the existing drivers as-is. Changing the iface is basically an incompatible change, and although most of applications and alsa-lib should look at both ifaces, there can be any surprise by that change. thanks, Takashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B85C2B9F8 for ; Tue, 25 May 2021 09:27:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8194A61360 for ; Tue, 25 May 2021 09:27:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8194A61360 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AC6606E9D1; Tue, 25 May 2021 09:27:38 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D53F6E9D1 for ; Tue, 25 May 2021 09:27:36 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621934855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQlYaaBAybmBVUAGlRLhcaeBlT3WUi4ttbQdnsQvkkc=; b=Z5IFxkkqBLurgeYrmix32ALtnLT8lESgjZwzcw8pSHjE1t+wVxLtaTAnEY84Yd8srphYjb DXNkN7/1wWh/OZndYtoGp7JzrnNS1qEB+GU+VdSDfY2HXaraGUWGpzKArrrq7N0sgT1kWp smaoRynoJTMxNcR8pCYrm/mLTnIusIg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621934855; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQlYaaBAybmBVUAGlRLhcaeBlT3WUi4ttbQdnsQvkkc=; b=w5nx12E3s3jTBrzYYio/pTtjlRrpP2if1P01HcjOBFvnQvkKvT9WoFa60nHBjeZKOVFGfl MfRFxF961C/czXCg== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CF558AECB; Tue, 25 May 2021 09:27:34 +0000 (UTC) Date: Tue, 25 May 2021 11:27:34 +0200 Message-ID: From: Takashi Iwai To: Maxime Ripard Subject: Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec In-Reply-To: <20210525092353.mvqdv4bi4i4rkqsu@gilmour> References: <20210507140334.204865-1-maxime@cerno.tech> <20210524133904.kgkh6xd3m5c2j3xa@gilmour> <20210525092353.mvqdv4bi4i4rkqsu@gilmour> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Tim Gover , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , Phil Elwell , Dave Stevenson , Takashi Iwai , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, Nicolas Saenz Julienne , Mark Brown , linux-rpi-kernel@lists.infradead.org, Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, Dom Cobley , Liam Girdwood , Rob Herring , Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 25 May 2021 11:23:53 +0200, Maxime Ripard wrote: > > Hi Takashi, > > On Tue, May 25, 2021 at 10:35:14AM +0200, Takashi Iwai wrote: > > On Mon, 24 May 2021 15:39:04 +0200, > > Maxime Ripard wrote: > > > > > > Hi, > > > > > > On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > > > > Hi, > > > > > > > > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place, > > > > it's missing a few controls to be able to provide HBR passthrough. This series > > > > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > > > > controller driver. > > > > > > > > One thing that felt a bit weird is that even though > > > > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-driver.html#iec958-s-pdif > > > > mentions that the iec958 mask control should be a mixer control and the > > > > default control should be a PCM one, it feels a bit weird to have two different > > > > control type for two controls so similar, and other drivers are pretty > > > > inconsistent with this. Should we update the documentation? > > > > > > Any comments on this series? > > > > A patch for updating the documentation is welcome. > > Currently, as de facto standard, we allow both MIXER and PCM ifaces > > for all IEC958-related controls, and it's unlikely that we would > > change that in future. > > Ok, I'll write a patch for the documentation make it clearer then :) > > Do we want to make sure that all the iec958 controls are on the same > iface, or is it also left to the driver (or should we just leave the > existing drivers as is but encourage a consistent use in the future)? I'd leave the existing drivers as-is. Changing the iface is basically an incompatible change, and although most of applications and alsa-lib should look at both ifaces, there can be any surprise by that change. thanks, Takashi