From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D061CC4363D for ; Tue, 6 Oct 2020 12:14:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A3A1206BE for ; Tue, 6 Oct 2020 12:14:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="HqJr8LKe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A3A1206BE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 89ECA1754; Tue, 6 Oct 2020 14:13:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 89ECA1754 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601986478; bh=g+EpKnXsfOfCioUksWmQsDovMHafDSAuh/xxhLyv0VA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HqJr8LKeV9gLneHwG/SJFopns17WWW7nzKJytdIY0459KqNQRPO726/fG+OziZSk3 gklWA0fuLRYNviPjzbUoniU6VyieAc9WPBFipJW4/2bDSlrjaUyE2Ols9278HGqonp bJB666JCTGZVHUrDCeXzZxZkwvIzJpgtgabhIvbM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 18583F80129; Tue, 6 Oct 2020 14:13:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F2A30F8012A; Tue, 6 Oct 2020 14:13:45 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 81397F80053 for ; Tue, 6 Oct 2020 14:13:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 81397F80053 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AE2FBAA55; Tue, 6 Oct 2020 12:13:40 +0000 (UTC) Date: Tue, 06 Oct 2020 14:13:40 +0200 Message-ID: From: Takashi Iwai To: Kai Vehmanen Subject: Re: [RFC PATCH 0/2] ALSA: hda - acomp probe fix for i915 In-Reply-To: <20201006113042.471718-1-kai.vehmanen@linux.intel.com> References: <20201006113042.471718-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 06 Oct 2020 13:30:40 +0200, Kai Vehmanen wrote: > > Hi, > > this simple bugfix started to feel a bit like getting stuck in quicksand, > so I'm looking for some early input via this RFC series. > > Basicly hdac_i915.c should not use global state to track communication > with i915 driver. But how to get handle of "hdac_bus*? I considered > a few options: > > 1) add hdac_bus as a member of drm_audio_component.h > -> seems wrong as this is really an audio side implementation) > > 2) embed copy of drm_audio_component to 'struct hdac_bus', so > I could use container_of() on the device handle to get > to the bus > -> wasted space to keep a copy at hdac_bus level > (note: snd-hda-codec-hdmi do this by embedding a copy > of ops to "struct hdmi_spec") > > 3) add another devres entry to store the hdac_bus directly > in acomp_init and a new helper function to query it > > I now implemented option 3 in this RFC series as it seemed cleanest > and most local to hdac_component.c, where the problem stems from. It's still > somewhat messy, and I'm wondering if I'm overlooking some obvious alternative. > We could dig this deeper into i915 specific code, but OTOH, hdac_bus is > an argument snd_hdac_acomp_init(), so it's common for all. > > Kai Vehmanen (2): > ALSA: hda - keep track of HDA core bus instance in acomp > ALSA: hda/i915 - fix list corruption with concurrent probes Another option would be to move the completion into the common acomp helper from i915-specific one. That is, - Add bind_complete field into struct drm_audio_component, initialize it at snd_hdac_acomp_init() - Call complete_all(&acomp->bind_complete) at the end of hdac_component_master_bind() - Remove / replace i915's own completion with the hdac's one. The i915_init_ops can be dropped. thanks, Takashi