From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE82FC352A2 for ; Fri, 7 Feb 2020 08:23:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 376BF20726 for ; Fri, 7 Feb 2020 08:23:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="mCU2I5o1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 376BF20726 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A575516AA; Fri, 7 Feb 2020 09:23:06 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A575516AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581063836; bh=VVqeo4NpCvZ/VcNWvvfSR0bs1/3Rnia7LDx1VZxfEjw=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mCU2I5o19OcFLLWws9c/wzbZfIElWYPcFZoGuXW5pB5EKM/u0/CqDsG85ZWZRKCqu qPcK03X9pnC2tVrMGYEvxu8b08htJ6Fu1es1O7UkrRdI+X78KIl+g3G5At316qfWZi Q6rMy+1yw5Q2ykfgtBfBrzx/oJdtaW6+QgY94Qiw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 338F3F80150; Fri, 7 Feb 2020 09:22:00 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2250FF80273; Fri, 7 Feb 2020 09:21:58 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7FEFEF80150 for ; Fri, 7 Feb 2020 09:21:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7FEFEF80150 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 317ECB048; Fri, 7 Feb 2020 08:21:55 +0000 (UTC) Date: Fri, 07 Feb 2020 09:21:55 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen In-Reply-To: <20200206200223.7715-3-kai.vehmanen@linux.intel.com> References: <20200206200223.7715-1-kai.vehmanen@linux.intel.com> <20200206200223.7715-3-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, broonie@kernel.org, pierre-louis.bossart@linux.intel.com, ranjani.sridharan@linux.intel.com Subject: Re: [alsa-devel] [PATCH 3/3] ASoC: SOF: Intel: hda: move i915 init earlier X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 06 Feb 2020 21:02:23 +0100, Kai Vehmanen wrote: > > To be compliant with i915 display driver requirements, i915 power-up > must be done before any HDA communication takes place, including > parsing the bus capabilities. Otherwise the initial codec probe > may fail. > > Move i915 initialization earlier in the SOF HDA sequence. This > sequence is now aligned with the snd-hda-intel driver where the > display_power() call is before snd_hdac_bus_parse_capabilities() > and rest of the capability parsing. > > Also remove unnecessary ifdef around hda_codec_i915_init(). There's > a dummy implementation provided if CONFIG_SND_SOC_SOF_HDA is not > enabled. > > Signed-off-by: Kai Vehmanen > Reviewed-by: Ranjani Sridharan > Reviewed-by: Pierre-Louis Bossart Reviewed-by: Takashi Iwai thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel