All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Hui Wang <hui.wang@canonical.com>
Cc: "Yang, Libin" <libin.yang@intel.com>,
	"'alsa-devel@alsa-project.org'" <alsa-devel@alsa-project.org>,
	"'broonie@kernel.org'" <broonie@kernel.org>,
	"'pierre-louis.bossart@linux.intel.com'"
	<pierre-louis.bossart@linux.intel.com>
Subject: Re: [RFC PATCH 3/4] ASoC: hdac_hdmi: refine hdmi jacks
Date: Thu, 27 Jun 2019 08:38:45 +0200	[thread overview]
Message-ID: <s5hpnmzr0qy.wl-tiwai@suse.de> (raw)
In-Reply-To: <7b42cbfe-e5f5-143b-a42d-f45be999311f@canonical.com>

On Tue, 25 Jun 2019 13:41:58 +0200,
Hui Wang wrote:
> 
> 
> On 2019/6/25 下午7:05, Takashi Iwai wrote:
> > On Tue, 25 Jun 2019 08:02:45 +0200,
> > Yang, Libin wrote:
> >>> Sorry for a long delay for the hdmi jacks. I was busy on another critical issue
> >>> last 2 weeks. I have worked out the UCM configuration files. Please check the
> >>> attachment. It is a long file, so I use the attachment instead of the patch mode.
> >>> Based on my test, it works well. Could you please help review if the
> >>> configuration file is OK or not. I will do more test on the meantime, including
> >>> DPMST and NON-DPMST.
> >> With some more tests on the new hdmi jack with UCM configuration, I found
> >> that the kernel patch can always notify the jack hotplug event to userspace
> >> correctly. However, the userspace can't set the amixer correctly based on
> >> the UCM configurations sometimes.
> >>
> >> Here is the details:
> >> There are 3 PCMs on Intel platforms. Let's call them pcm1, pcm2, pcm3.
> >> And there are 3 pins (pin5, pin6, pin7). For DPMST, and each pin has 3 ports:
> >> port0, port1, port2.
> >>
> >> For non-DPMST, we can set pin5 <=> pcm1, pin6 <=> pcm2, pin7 <=> pcm3.
> >> This can always work.
> >>
> >> For DPMST, as there are 9 ports using 3 pcms. So we should assign
> >> 1 pcm to 3 ports. For example, pin5-port0, pin6-port1 and pin7-port2
> >> are using pcm1;  pin5-port1, pin6-port2 and pin7-port0 are using
> >> pcm2; pin5-port2; pin6-port3 and pin7-port1 are using pcm3.
> >> In this setting, we should setting the ConflictingDevice in UCM.
> >> For example, pin5-port0 is conflicting with pin6-port1 and pin7-port2.
> >> Hui and I found if we set one device conflicting with 2 devices, the
> >> amixer setting will be wrong and it will not following UCM configuration
> >> setting when we are hotplugging the monitors.
> > How wrong would it behave?  Only one of them is done?
> 
> Yes, only the 1st conflicting device is handled.
> 
> for example:
> 
> pin5-port0 has two conflicting devices: pin6-port1 and pin7-port2,
> 
> When pin5-port0 is active in the pulseaudio, I can see the
> pin6-port1.DisableSequece and pin7-port2.DisableSequence are called
> according to pulseaudio's log, but it looks like the commands only in
> the 1st device (pin6-port1.DisableSequence) are executed.
> 
> To call conflicting devices' disablesequence, the pulseaudio will call
> snd_use_case_set(ucm->ucm_mgr, "_disdev", dev_name) twice, but only
> the 1st time calling takes effect.

If you reached at that point, you can continue tracking in alsa-lib :)
If it's some weird behavior in set_device(), it must be either the
list management failure in UCM or execute_sequence() misses
something.


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-06-27  6:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27  9:07 [RFC PATCH 0/4] ASoC: hdac_hdmi: refine the hdac_hdmi jacks libin.yang
2019-05-27  9:07 ` [RFC PATCH 1/4] ASoC: hdac_hdmi: amixer kctl setting should not impact on jack status libin.yang
2019-05-27  9:07 ` [RFC PATCH 2/4] ASoC: hdac_hdmi: jack_event represents the status libin.yang
2019-05-27  9:07 ` [RFC PATCH 3/4] ASoC: hdac_hdmi: refine hdmi jacks libin.yang
2019-05-30  7:13   ` Takashi Iwai
2019-05-30 15:00     ` Yang, Libin
2019-05-30 15:22       ` Takashi Iwai
2019-05-31  2:27         ` Yang, Libin
2019-06-14  8:04           ` Yang, Libin
2019-06-25  6:02             ` Yang, Libin
2019-06-25 11:05               ` Takashi Iwai
2019-06-25 11:41                 ` Hui Wang
2019-06-27  6:38                   ` Takashi Iwai [this message]
2019-06-27  1:46                 ` Yang, Libin
2019-05-27  9:07 ` [RFC PATCH 4/4] ASoC: hdac_hdmi: fix some coding style issue libin.yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpnmzr0qy.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=hui.wang@canonical.com \
    --cc=libin.yang@intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.