From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Support low power consumption for ALC3254 Date: Tue, 07 May 2019 11:15:23 +0200 Message-ID: References: <6FAB7C47BCF00940BB0999A99BE3547A1D765A46@RTITMBSVM07.realtek.com.tw> <6FAB7C47BCF00940BB0999A99BE3547A1D765A7C@RTITMBSVM07.realtek.com.tw> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8DC5DF807B5 for ; Tue, 7 May 2019 11:15:24 +0200 (CEST) In-Reply-To: <6FAB7C47BCF00940BB0999A99BE3547A1D765A7C@RTITMBSVM07.realtek.com.tw> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Kailang Cc: " (alsa-devel@alsa-project.org)" List-Id: alsa-devel@alsa-project.org On Tue, 07 May 2019 11:07:14 +0200, Kailang wrote: > > Hi Takashi, > > I had sent other patch before. > Could it can apply? Which patch, specifically? > > -----Original Message----- > > From: Takashi Iwai > > Sent: Tuesday, May 7, 2019 4:40 PM > > To: Kailang > > Cc: (alsa-devel@alsa-project.org) > > Subject: Re: Support low power consumption for ALC3254 > > > > On Tue, 07 May 2019 09:53:24 +0200, > > Kailang wrote: > > > > > > Hi Takashi, > > > > > > Chrome OS want to support low power consumption. > > > This patch will support low consumption. > > > > Looks mostly OK, but one question: why hp_pin isn't set? > > If hp_pin not assigned, depop procedure must run. > So, if system doesn't have HP. It must assigned default 0x21 pin to run depop procedure. OK, point taken. So it's not a headphone pin but other output pin that requires the same depop workaround. Now applied the patch. Thanks. Takashi