From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] conf: topology: Add topolgy for skylake i2s configuration Date: Tue, 09 Feb 2016 14:18:58 +0100 Message-ID: References: <1454903756-2075-1-git-send-email-subhransu.s.prusty@intel.com> <20160209114749.GA7243@subhransu-desktop> <20160209131415.GA26322@subhransu-desktop> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id F121E2619BF for ; Tue, 9 Feb 2016 14:18:58 +0100 (CET) In-Reply-To: <20160209131415.GA26322@subhransu-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Subhransu S. Prusty" Cc: patches.audio@intel.com, Vinod Koul , alsa-devel@alsa-project.org, broonie@kernel.org, lgirdwood@gmail.com List-Id: alsa-devel@alsa-project.org On Tue, 09 Feb 2016 14:14:19 +0100, Subhransu S. Prusty wrote: > > On Tue, Feb 09, 2016 at 12:54:39PM +0100, Takashi Iwai wrote: > > On Tue, 09 Feb 2016 12:47:53 +0100, > > Subhransu S. Prusty wrote: > > > > > > On Tue, Feb 09, 2016 at 12:15:45PM +0100, Takashi Iwai wrote: > > > > On Mon, 08 Feb 2016 04:55:56 +0100, > > > > Subhransu S. Prusty wrote: > > > > > > > > > > This patch adds basic playback/capture support for skylake i2s > > > > > platform. DSP topology module data are passed through the binary > > > > > files. The framework parses these files and puts the data in the > > > > > widget private section for the corresponding widget. This is > > > > > parsed by kernel driver and stored as module config for the DSP. > > > > > Based on usecase these data are sent to the DSP through IPCs for > > > > > further processing. > > > > > > > > Can we have sources for these binaries, or do they have to be > > > > binary-only? > > > > > > Hi Takashi, > > > > > > These are binary only data. > > > > Then this isn't a good material for merging to alsa-lib. How is the > > license compatibility? > > Each binary file here holds config for each module based on skl_dfw_module > structure as expected by Skylake driver. The skl driver formats IPCs parsing > this config. > > This structure skl_dfw_module is already defined as part of > skl-tplg-interface.h. Well, the question is whether this IP is a programmed data block, not some simple numbers. If yes, it's always a question whether it's compatible with GPL. Although alsa-lib is LGPL, putting the binary blob in the *code tree* doesn't look good to me. IMO, this should go to firmware tree instead, unless you can give the source code to build the binary. Takashi