All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek - Add quirk for Mac Pro 5,1 machines
@ 2012-04-12 17:55 Josh Boyer
  2012-04-12 18:05   ` [PATCH] ALSA: hda/realtek - Add quirk for Mac Pro 5, 1 machines Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Josh Boyer @ 2012-04-12 17:55 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel, Gabriel Somlo, linux-kernel, kernel-team

A user reported that setting model=imac24 used to allow sound to work on their
Mac Pro 5,1 machine.  Commit 5671087ffa "Move ALC885 macpro and imac24 models
to auto-parser" removed this model option.  All Mac machines are now explicitly
handled with a quirk and the auto-parser.  This adds a quirk for the device
found on the Mac Pro 5,1 machines.

This (partially) fixes https://bugzilla.redhat.com/show_bug.cgi?id=808559

Reported-by: Gabriel Somlo <somlo@cmu.edu>
Signed-off-by: Josh Boyer <jwboyer@redhat.com>

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 9917e55..1e0eea8 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5371,6 +5371,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x106b, 0x00a1, "Macbook", ALC889_FIXUP_MBP_VREF),
 	SND_PCI_QUIRK(0x106b, 0x00a4, "MacbookPro 4,1", ALC889_FIXUP_MBP_VREF),
 	SND_PCI_QUIRK(0x106b, 0x0c00, "Mac Pro", ALC885_FIXUP_MACPRO_GPIO),
+	SND_PCI_QUIRK(0x106b, 0x4200,  "Mac Pro 5,1", ALC885_FIXUP_MACPRO_GPIO),
 	SND_PCI_QUIRK(0x106b, 0x1000, "iMac 24", ALC885_FIXUP_MACPRO_GPIO),
 	SND_PCI_QUIRK(0x106b, 0x2800, "AppleTV", ALC885_FIXUP_MACPRO_GPIO),
 	SND_PCI_QUIRK(0x106b, 0x2c00, "MacbookPro rev3", ALC889_FIXUP_MBP_VREF),
-- 
1.7.7.6


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: hda/realtek - Add quirk for Mac Pro 5,1 machines
  2012-04-12 17:55 [PATCH] ALSA: hda/realtek - Add quirk for Mac Pro 5,1 machines Josh Boyer
@ 2012-04-12 18:05   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2012-04-12 18:05 UTC (permalink / raw)
  To: Josh Boyer; +Cc: alsa-devel, Gabriel Somlo, linux-kernel, kernel-team

At Thu, 12 Apr 2012 13:55:36 -0400,
Josh Boyer wrote:
> 
> A user reported that setting model=imac24 used to allow sound to work on their
> Mac Pro 5,1 machine.  Commit 5671087ffa "Move ALC885 macpro and imac24 models
> to auto-parser" removed this model option.  All Mac machines are now explicitly
> handled with a quirk and the auto-parser.  This adds a quirk for the device
> found on the Mac Pro 5,1 machines.
> 
> This (partially) fixes https://bugzilla.redhat.com/show_bug.cgi?id=808559
> 
> Reported-by: Gabriel Somlo <somlo@cmu.edu>
> Signed-off-by: Josh Boyer <jwboyer@redhat.com>

Applied now (with sorting in the id number order).
Thanks.


Takashi


> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 9917e55..1e0eea8 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5371,6 +5371,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x106b, 0x00a1, "Macbook", ALC889_FIXUP_MBP_VREF),
>  	SND_PCI_QUIRK(0x106b, 0x00a4, "MacbookPro 4,1", ALC889_FIXUP_MBP_VREF),
>  	SND_PCI_QUIRK(0x106b, 0x0c00, "Mac Pro", ALC885_FIXUP_MACPRO_GPIO),
> +	SND_PCI_QUIRK(0x106b, 0x4200,  "Mac Pro 5,1", ALC885_FIXUP_MACPRO_GPIO),
>  	SND_PCI_QUIRK(0x106b, 0x1000, "iMac 24", ALC885_FIXUP_MACPRO_GPIO),
>  	SND_PCI_QUIRK(0x106b, 0x2800, "AppleTV", ALC885_FIXUP_MACPRO_GPIO),
>  	SND_PCI_QUIRK(0x106b, 0x2c00, "MacbookPro rev3", ALC889_FIXUP_MBP_VREF),
> -- 
> 1.7.7.6
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: hda/realtek - Add quirk for Mac Pro 5, 1 machines
@ 2012-04-12 18:05   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2012-04-12 18:05 UTC (permalink / raw)
  To: Josh Boyer; +Cc: kernel-team, alsa-devel, Gabriel Somlo, linux-kernel

At Thu, 12 Apr 2012 13:55:36 -0400,
Josh Boyer wrote:
> 
> A user reported that setting model=imac24 used to allow sound to work on their
> Mac Pro 5,1 machine.  Commit 5671087ffa "Move ALC885 macpro and imac24 models
> to auto-parser" removed this model option.  All Mac machines are now explicitly
> handled with a quirk and the auto-parser.  This adds a quirk for the device
> found on the Mac Pro 5,1 machines.
> 
> This (partially) fixes https://bugzilla.redhat.com/show_bug.cgi?id=808559
> 
> Reported-by: Gabriel Somlo <somlo@cmu.edu>
> Signed-off-by: Josh Boyer <jwboyer@redhat.com>

Applied now (with sorting in the id number order).
Thanks.


Takashi


> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 9917e55..1e0eea8 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5371,6 +5371,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x106b, 0x00a1, "Macbook", ALC889_FIXUP_MBP_VREF),
>  	SND_PCI_QUIRK(0x106b, 0x00a4, "MacbookPro 4,1", ALC889_FIXUP_MBP_VREF),
>  	SND_PCI_QUIRK(0x106b, 0x0c00, "Mac Pro", ALC885_FIXUP_MACPRO_GPIO),
> +	SND_PCI_QUIRK(0x106b, 0x4200,  "Mac Pro 5,1", ALC885_FIXUP_MACPRO_GPIO),
>  	SND_PCI_QUIRK(0x106b, 0x1000, "iMac 24", ALC885_FIXUP_MACPRO_GPIO),
>  	SND_PCI_QUIRK(0x106b, 0x2800, "AppleTV", ALC885_FIXUP_MACPRO_GPIO),
>  	SND_PCI_QUIRK(0x106b, 0x2c00, "MacbookPro rev3", ALC889_FIXUP_MBP_VREF),
> -- 
> 1.7.7.6
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-12 18:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-12 17:55 [PATCH] ALSA: hda/realtek - Add quirk for Mac Pro 5,1 machines Josh Boyer
2012-04-12 18:05 ` Takashi Iwai
2012-04-12 18:05   ` [PATCH] ALSA: hda/realtek - Add quirk for Mac Pro 5, 1 machines Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.