From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934558Ab2DLSFJ (ORCPT ); Thu, 12 Apr 2012 14:05:09 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47191 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933262Ab2DLSFG (ORCPT ); Thu, 12 Apr 2012 14:05:06 -0400 Date: Thu, 12 Apr 2012 20:05:05 +0200 Message-ID: From: Takashi Iwai To: Josh Boyer Cc: alsa-devel@alsa-project.org, Gabriel Somlo , linux-kernel@vger.kernel.org, kernel-team@fedoraproject.org Subject: Re: [PATCH] ALSA: hda/realtek - Add quirk for Mac Pro 5,1 machines In-Reply-To: <20120412175536.GB25425@zod.bos.redhat.com> References: <20120412175536.GB25425@zod.bos.redhat.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 12 Apr 2012 13:55:36 -0400, Josh Boyer wrote: > > A user reported that setting model=imac24 used to allow sound to work on their > Mac Pro 5,1 machine. Commit 5671087ffa "Move ALC885 macpro and imac24 models > to auto-parser" removed this model option. All Mac machines are now explicitly > handled with a quirk and the auto-parser. This adds a quirk for the device > found on the Mac Pro 5,1 machines. > > This (partially) fixes https://bugzilla.redhat.com/show_bug.cgi?id=808559 > > Reported-by: Gabriel Somlo > Signed-off-by: Josh Boyer Applied now (with sorting in the id number order). Thanks. Takashi > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 9917e55..1e0eea8 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5371,6 +5371,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = { > SND_PCI_QUIRK(0x106b, 0x00a1, "Macbook", ALC889_FIXUP_MBP_VREF), > SND_PCI_QUIRK(0x106b, 0x00a4, "MacbookPro 4,1", ALC889_FIXUP_MBP_VREF), > SND_PCI_QUIRK(0x106b, 0x0c00, "Mac Pro", ALC885_FIXUP_MACPRO_GPIO), > + SND_PCI_QUIRK(0x106b, 0x4200, "Mac Pro 5,1", ALC885_FIXUP_MACPRO_GPIO), > SND_PCI_QUIRK(0x106b, 0x1000, "iMac 24", ALC885_FIXUP_MACPRO_GPIO), > SND_PCI_QUIRK(0x106b, 0x2800, "AppleTV", ALC885_FIXUP_MACPRO_GPIO), > SND_PCI_QUIRK(0x106b, 0x2c00, "MacbookPro rev3", ALC889_FIXUP_MBP_VREF), > -- > 1.7.7.6 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda/realtek - Add quirk for Mac Pro 5, 1 machines Date: Thu, 12 Apr 2012 20:05:05 +0200 Message-ID: References: <20120412175536.GB25425@zod.bos.redhat.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id E3232243BE for ; Thu, 12 Apr 2012 20:05:05 +0200 (CEST) In-Reply-To: <20120412175536.GB25425@zod.bos.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Josh Boyer Cc: kernel-team@fedoraproject.org, alsa-devel@alsa-project.org, Gabriel Somlo , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org At Thu, 12 Apr 2012 13:55:36 -0400, Josh Boyer wrote: > > A user reported that setting model=imac24 used to allow sound to work on their > Mac Pro 5,1 machine. Commit 5671087ffa "Move ALC885 macpro and imac24 models > to auto-parser" removed this model option. All Mac machines are now explicitly > handled with a quirk and the auto-parser. This adds a quirk for the device > found on the Mac Pro 5,1 machines. > > This (partially) fixes https://bugzilla.redhat.com/show_bug.cgi?id=808559 > > Reported-by: Gabriel Somlo > Signed-off-by: Josh Boyer Applied now (with sorting in the id number order). Thanks. Takashi > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 9917e55..1e0eea8 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5371,6 +5371,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = { > SND_PCI_QUIRK(0x106b, 0x00a1, "Macbook", ALC889_FIXUP_MBP_VREF), > SND_PCI_QUIRK(0x106b, 0x00a4, "MacbookPro 4,1", ALC889_FIXUP_MBP_VREF), > SND_PCI_QUIRK(0x106b, 0x0c00, "Mac Pro", ALC885_FIXUP_MACPRO_GPIO), > + SND_PCI_QUIRK(0x106b, 0x4200, "Mac Pro 5,1", ALC885_FIXUP_MACPRO_GPIO), > SND_PCI_QUIRK(0x106b, 0x1000, "iMac 24", ALC885_FIXUP_MACPRO_GPIO), > SND_PCI_QUIRK(0x106b, 0x2800, "AppleTV", ALC885_FIXUP_MACPRO_GPIO), > SND_PCI_QUIRK(0x106b, 0x2c00, "MacbookPro rev3", ALC889_FIXUP_MBP_VREF), > -- > 1.7.7.6 >