From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 21/21] ASoC: SOF: Add Build support for SOF
	core and Intel drivers
Date: Wed, 12 Dec 2018 12:50:35 +0100
Message-ID: <s5hr2enj75g.wl-tiwai@suse.de>
References: <20181211213029.28801-1-pierre-louis.bossart@linux.intel.com>
 <20181211213029.28801-22-pierre-louis.bossart@linux.intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
In-Reply-To: <20181211213029.28801-22-pierre-louis.bossart@linux.intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, andriy.shevchenko@intel.com, Daniel Baluta <daniel.baluta@gmail.com>, liam.r.girdwood@linux.intel.com, vkoul@kernel.org, broonie@kernel.org, Alan Cox <alan@linux.intel.com>, sound-open-firmware@alsa-project.org
List-Id: alsa-devel@alsa-project.org

On Tue, 11 Dec 2018 22:30:29 +0100,
Pierre-Louis Bossart wrote:
> 
> --- /dev/null
> +++ b/sound/soc/sof/Kconfig
> @@ -0,0 +1,82 @@
> +config SND_SOC_SOF_PCI
> +	tristate
> +
> +config SND_SOC_SOF_ACPI
> +	tristate
> +
> +config SND_SOC_SOF
> +	tristate "Sound Open Firmware Support"
> +	select SND_SOC_TOPOLOGY
> +	help
> +          This adds support for Sound Open Firmware (SOF). SOF is a free and
> +	  generic open source audio DSP firmware for multiple devices.
> +          Say Y if you have such a device that is supported by SOF.
> +          If unsure select "N".

You can put
  if SND_SOC_SOF
at this point.  This will reduce lots of "depends on SND_SOC_SOF"
lines.

> +config SND_SOC_SOF_NOCODEC
> +	tristate "SOF nocodec mode Support"
> +	depends on SND_SOC_SOF
....
> +source "sound/soc/sof/intel/Kconfig"
> +source "sound/soc/sof/xtensa/Kconfig"

... the endif for SND_SOC_SOF can be put here, then both Kconfigs are
covered by SND_SOC_SOF condition.


OTOH, the usage of if-block below is an overkill.

> --- /dev/null
> +++ b/sound/soc/sof/intel/Kconfig
....
> +if SND_SOC_SOF_HDA_COMMON
> +
> +config SND_SOC_SOF_HDA_LINK
> +	bool "SOF support for HDA Links(HDA/HDMI)"
> +	help
> +          This adds support for HDA links(HDA/HDMI) with Sound Open Firmware
> +		  for Intel(R) platforms.
> +          Say Y if you want to enble HDA links with SOF.
> +          If unsure select "N".
> +
> +if SND_SOC_SOF_HDA_LINK
> +config SND_SOC_SOF_HDA_AUDIO_CODEC
> +	bool "SOF support for HDAudio codecs"
> +	help
> +          This adds support for HDAudio codecs with Sound Open Firmware
> +		  for Intel(R) platforms.
> +          Say Y if you want to enble HDAudio codecs with SOF.
> +          If unsure select "N".
> +endif ## SND_SOC_SOF_HDA_LINK
> +
> +endif ## SND_SOC_SOF_HDA_COMMON

For single items, just use depends on.  It's easier to read.


thanks,

Takashi