From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v2 1/9] ALSA: line6: Make driver
	configuration more generic.
Date: Wed, 24 Aug 2016 16:50:47 +0200
Message-ID: <s5hr39e2pbs.wl-tiwai@suse.de>
References: <1470942147-19848-1-git-send-email-dev@andree.sk>
 <1471558839-14120-1-git-send-email-dev@andree.sk>
 <1471558839-14120-2-git-send-email-dev@andree.sk>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id A2BCE269E36
 for <alsa-devel@alsa-project.org>; Wed, 24 Aug 2016 16:50:47 +0200 (CEST)
In-Reply-To: <1471558839-14120-2-git-send-email-dev@andree.sk>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Andrej Krutak <dev@andree.sk>
Cc: stefanha@gmail.com, alsa-devel@alsa-project.org, grabner@icg.tugraz.at
List-Id: alsa-devel@alsa-project.org

On Fri, 19 Aug 2016 00:20:31 +0200,
Andrej Krutak wrote:
> 
> The main reasons are different settings for USB low/high speed and possible
> different channel counts for in/out; required by POD X3.
> 
> This consists of two related parts:
> 
> Support for high-speed USB:
> * USB_INTERVALS_PER_SECOND -> LOW/HIGH settings
>   (high needs 8000, instead of 1000)
> * LINE6_ISO_BUFFERS -> iso_buffers (count of iso buffers depends on
>   USB speed, 2 is not enough for high speed)
> 
> Support for assymetrical in/out configurations:
> * bytes_per_frame -> bytes_per_channel
> * max_packet_size -> max_packet_size_in/out

It'd be better to split into a few more patches.  The changes about
making iso_buffers dynamic and others are basically independent.

So, as the first patch, just convert to the dynamic urbs allocation
and adding line6->iso_buffers field, as a preliminary change.
Then introduce the two speed modes and align iso_buffers in the next
patch.  And at last, convert bytes_per_frame and max_packet_size.
They can be either one or two individual patches, too.

Also, just a nitpick:

> +	index = find_first_zero_bit(
> +		&line6pcm->in.active_urbs, line6pcm->line6->iso_buffers);

This style (leaving the open parenthesis) isn't common in the kernel
code.


thanks,

Takashi