From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 867C3C433EF for ; Thu, 11 Nov 2021 09:24:43 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 022DD6108B for ; Thu, 11 Nov 2021 09:24:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 022DD6108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 56CC81657; Thu, 11 Nov 2021 10:23:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 56CC81657 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1636622681; bh=pXkPmS0qYVi6ua9GRd+ySzGpm0LusSbPPrFOQx6WB9c=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YGKqokyEWb/FTrTqECKdQ18NZedEdpZ6bDGJFzL5VK71Tasrzvg1cz3G65J0jkTg5 vUxQTnP4LJLrTYvv6c/LhddYNY75sbGL12ggs+ynq999qLmKTCE6b84uCgxkSxX/lp 0g096pgzjjyWV10cN3ltyGHIIkLNJ4jzMA8AsPkw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D5750F80224; Thu, 11 Nov 2021 10:23:50 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A0EE2F80086; Thu, 11 Nov 2021 10:23:49 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8C80DF80086 for ; Thu, 11 Nov 2021 10:23:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8C80DF80086 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="JffQmFFV"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="rrZmXCXH" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 02E461FD2A; Thu, 11 Nov 2021 09:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1636622623; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FUT415KyQbptBMbOjsQPBwUhP0kW124rvO5hfcWEuTg=; b=JffQmFFVQjAcG8WCzLUmm5Up9xW5uPcb1+GrJDG2s6003OPtKJ2AK/dibqSQa48Uz+ay9+ ccfb519SdkbaPWYO7xHzK1+O5vV6qQQZuH1up2TmV7Euap7j5K76dDxGbOCYnWHUh4NVrx FfO2FlWqkjWAkQ+N+lB8Gk8u+DFC/As= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1636622623; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FUT415KyQbptBMbOjsQPBwUhP0kW124rvO5hfcWEuTg=; b=rrZmXCXHlcnCQH68l//3hMXWwPqsHyP5J4ziZw+AUhWaEMyVSc+NW36FvGDFjix9MGHq7v ga1D7hkqTREa4rBA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id C5AA5A3BED; Thu, 11 Nov 2021 09:23:42 +0000 (UTC) Date: Thu, 11 Nov 2021 10:23:42 +0100 Message-ID: From: Takashi Iwai To: Subject: Re: [PATCH] ALSA: usb-audio: add the profile name of Dell desktop In-Reply-To: <20211111091914.20917-1-shumingf@realtek.com> References: <20211111091914.20917-1-shumingf@realtek.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: oder_chiou@realtek.com, jack.yu@realtek.com, alsa-devel@alsa-project.org, lars@metafoo.de, lgirdwood@gmail.com, broonie@kernel.org, derek.fang@realtek.com, Yijun.Shen@dell.com, flove@realtek.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 11 Nov 2021 10:19:14 +0100, wrote: > > From: Shuming Fan > > Add the profile name to let userspace pick correct UCM profile Was the corresponding change for alsa-ucm-conf submitted to upstream? > Signed-off-by: Shuming Fan > --- > sound/usb/card.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sound/usb/card.c b/sound/usb/card.c > index 1764b9302d46..9c67ecbe710e 100644 > --- a/sound/usb/card.c > +++ b/sound/usb/card.c > @@ -398,6 +398,10 @@ static const struct usb_audio_device_name usb_audio_names[] = { > PROFILE_NAME(0x0bda, 0x4014, "Dell", "WD15 Dock", "Dell-WD15-Dock"), > /* Dell WD19 Dock */ > PROFILE_NAME(0x0bda, 0x402e, "Dell", "WD19 Dock", "Dell-WD15-Dock"), > + /* Dell Desktop - Front */ > + PROFILE_NAME(0x0bda, 0x4c54, "Dell", "Desktop", "Dell-Desktop-Front"), > + /* Dell Desktop - Rear */ > + PROFILE_NAME(0x0bda, 0x4c55, "Dell", "Desktop", "Dell-Desktop-Rear"), IMO, the profile name sounds too generic. It's better to have with some model name at least so that it can be identified more uniquely. thanks, Takashi