All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
	pierre-louis.bossart@linux.intel.com,
	ranjani.sridharan@linux.intel.com
Subject: Re: [alsa-devel] [PATCH 1/3] ALSA: hda: do not override bus codec_mask in link_get()
Date: Fri, 07 Feb 2020 09:21:20 +0100	[thread overview]
Message-ID: <s5hsgjmvmdb.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200206200223.7715-1-kai.vehmanen@linux.intel.com>

On Thu, 06 Feb 2020 21:02:21 +0100,
Kai Vehmanen wrote:
> 
> snd_hdac_ext_bus_link_get() does not work correctly in case
> there are multiple codecs on the bus. It unconditionally
> resets the bus->codec_mask value. As per documentation in
> hdaudio.h and existing use in client code, this field should
> be used to store bit flag of detected codecs on the bus.
> 
> By overwriting value of the codec_mask, information on all
> detected codecs is lost. No current user of hdac is impacted,
> but use of bus->codec_mask is planned in future patches
> for SOF.
> 
> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Reviewed-by: Takashi Iwai <tiwai@suse.de>

Mark, feel free to take this fix together with other two.


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2020-02-07  8:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06 20:02 [alsa-devel] [PATCH 1/3] ALSA: hda: do not override bus codec_mask in link_get() Kai Vehmanen
2020-02-06 20:02 ` [alsa-devel] [PATCH 2/3] ASoC: SOF: Intel: hda: fix ordering bug in resume flow Kai Vehmanen
2020-02-07  8:21   ` Takashi Iwai
2020-02-10 14:07   ` [alsa-devel] Applied "ASoC: SOF: Intel: hda: fix ordering bug in resume flow" to the asoc tree Mark Brown
2020-02-06 20:02 ` [alsa-devel] [PATCH 3/3] ASoC: SOF: Intel: hda: move i915 init earlier Kai Vehmanen
2020-02-07  8:21   ` Takashi Iwai
2020-02-10 14:07   ` [alsa-devel] Applied "ASoC: SOF: Intel: hda: move i915 init earlier" to the asoc tree Mark Brown
2020-02-07  8:21 ` Takashi Iwai [this message]
2020-02-10 14:07 ` [alsa-devel] Applied "ALSA: hda: do not override bus codec_mask in link_get()" " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hsgjmvmdb.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.