From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 19/19] ASoC: Intel: bytcr_rt5640: Set card long_name based on quirks Date: Sun, 13 May 2018 09:11:41 +0200 Message-ID: References: <20180508153604.23711-1-hdegoede@redhat.com> <20180508153604.23711-20-hdegoede@redhat.com> <6793d0f6-223b-2f11-17ad-d4ab839b4ac4@linux.intel.com> <4f678986-9ca5-eeb3-d6ed-528f3fe1d013@redhat.com> <84e7b889-7b42-47dc-bdf8-d01ac88a9e55@linux.intel.com> <1fd841b6-1e05-2cd9-8b0e-44524503a3fa@redhat.com> <19cd9f01-222c-ae6a-6244-d703ac646310@linux.intel.com> <86f6bb1e-21af-a2e4-76c4-c0446c3b32e8@redhat.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 6189E266F44 for ; Sun, 13 May 2018 09:11:42 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: Oder Chiou , alsa-devel@alsa-project.org, Liam Girdwood , Hans de Goede , Mark Brown , Bard Liao List-Id: alsa-devel@alsa-project.org On Sat, 12 May 2018 23:21:58 +0200, Pierre-Louis Bossart wrote: > > >> > >> splitting platform and codec sides is a good idea (and something > >> that was done by removing all platform mixer settings from the HiFi > >> files) > >> > >> the problem remains that we have all these cdev strings that are > >> hard-codec with a card name. Same when the match happens based on a > >> DMI string, how would I know which of the platform settings to > >> apply without querying what the platform driver is? > > > > Well the DMI string would uniquely identify a certain model device, > > when we write the UCM file we should know what the platform + codec > > for that device is and we can simply hardcode them, like in > > my example above. > > > > But maybe I'm misunderstanding you? > > For the same DMI device, you could either enable the existing > intel/sst or SOF drivers. How would we handle UCM configs then? The > DMI name would need to be augmented with a prefix, or we use > *something* to add the references to SOF in the platform include and > ALSA device string. You've already added the flavor suffix to snd_soc_set_dmi_name(), so they'll be unique, no? Takashi