From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752101AbdB1Pel (ORCPT ); Tue, 28 Feb 2017 10:34:41 -0500 Received: from mx2.suse.de ([195.135.220.15]:42222 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbdB1Pei (ORCPT ); Tue, 28 Feb 2017 10:34:38 -0500 Date: Tue, 28 Feb 2017 16:19:41 +0100 Message-ID: From: Takashi Iwai To: "Takashi Sakamoto" Cc: "Mihai Burduselu" , , , , , , , , Subject: Re: [PATCH] ASoC: dwc: remove 'out of memory' message In-Reply-To: <9da9efc3-cd9b-70a5-a764-e8be32e67d13@sakamocchi.jp> References: <20170225110323.7506-1-michelcatalin@gmail.com> <9da9efc3-cd9b-70a5-a764-e8be32e67d13@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 26 Feb 2017 09:03:22 +0100, Takashi Sakamoto wrote: > > Hi, > > On Feb 25 2017 20:03, Mihai Burduselu wrote: > > Reported by checkpatch.pl > > Signed-off-by: Mihai Burduselu > > --- > > sound/soc/dwc/designware_i2s.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c > > index 9c46e4112026..6479768cc6a1 100644 > > --- a/sound/soc/dwc/designware_i2s.c > > +++ b/sound/soc/dwc/designware_i2s.c > > @@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev) > > const char *clk_id; > > > > dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL); > > - if (!dev) { > > - dev_warn(&pdev->dev, "kzalloc fail\n"); > > + if (!dev) > > The line for 'dev_warn()' should be kept. In general, people regard it superfluous since kmalloc() itself already gives a kernel warning at an allocation error. So removing the message is OK in that sense. However, the problem of this (and lots of other) patch is that it doesn't give proper information. Instead, in a single line, it merely declares checkpatch.pl as a bible. Very helpful, eh? So, please reconsider the changelog when you submit this kind of patches. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ASoC: dwc: remove 'out of memory' message Date: Tue, 28 Feb 2017 16:19:41 +0100 Message-ID: References: <20170225110323.7506-1-michelcatalin@gmail.com> <9da9efc3-cd9b-70a5-a764-e8be32e67d13@sakamocchi.jp> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 6F993265142 for ; Tue, 28 Feb 2017 16:19:43 +0100 (CET) In-Reply-To: <9da9efc3-cd9b-70a5-a764-e8be32e67d13@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Sakamoto Cc: Jose.Abreu@synopsys.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, broonie@kernel.org, s.nawrocki@samsung.com, colin.king@canonical.com, Mihai Burduselu List-Id: alsa-devel@alsa-project.org On Sun, 26 Feb 2017 09:03:22 +0100, Takashi Sakamoto wrote: > > Hi, > > On Feb 25 2017 20:03, Mihai Burduselu wrote: > > Reported by checkpatch.pl > > Signed-off-by: Mihai Burduselu > > --- > > sound/soc/dwc/designware_i2s.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c > > index 9c46e4112026..6479768cc6a1 100644 > > --- a/sound/soc/dwc/designware_i2s.c > > +++ b/sound/soc/dwc/designware_i2s.c > > @@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev) > > const char *clk_id; > > > > dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL); > > - if (!dev) { > > - dev_warn(&pdev->dev, "kzalloc fail\n"); > > + if (!dev) > > The line for 'dev_warn()' should be kept. In general, people regard it superfluous since kmalloc() itself already gives a kernel warning at an allocation error. So removing the message is OK in that sense. However, the problem of this (and lots of other) patch is that it doesn't give proper information. Instead, in a single line, it merely declares checkpatch.pl as a bible. Very helpful, eh? So, please reconsider the changelog when you submit this kind of patches. thanks, Takashi