From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 2/5] ALSA: usb-audio: purge needless variable length array Date: Mon, 20 Feb 2017 21:51:54 +0100 Message-ID: References: <20170220200921.824-1-o-takashi@sakamocchi.jp> <20170220200921.824-3-o-takashi@sakamocchi.jp> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id ADEBB266BCA for ; Mon, 20 Feb 2017 21:51:54 +0100 (CET) In-Reply-To: <20170220200921.824-3-o-takashi@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Sakamoto Cc: onkel@paraair.de, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Mon, 20 Feb 2017 21:09:18 +0100, Takashi Sakamoto wrote: > > Variable length array is used in 'snd_us16x08_meter_get()', while there > is logically no need. It's better to purge it because variable length array > has overhead for stack handling. > > This commit replaces the array with static length. Sparse generated below > warning. > > sound/usb/mixer_us16x08.c:714:18: warning: Variable length array is used. > > Fixes: d2bb390a2081 ("ALSA: usb-audio: Tascam US-16x08 DSP mixer quirk") > Signed-off-by: Takashi Sakamoto Applied, thanks. Takashi