From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932090AbbE1OJW (ORCPT ); Thu, 28 May 2015 10:09:22 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53097 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbbE1OJL (ORCPT ); Thu, 28 May 2015 10:09:11 -0400 Date: Thu, 28 May 2015 16:09:10 +0200 Message-ID: From: Takashi Iwai To: Quentin Lambert Cc: Johannes Berg , Jaroslav Kysela , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups In-Reply-To: <55671F56.6080402@gmail.com> References: <1432817307-28380-1-git-send-email-lambert.quentin@gmail.com> <55671F56.6080402@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 28 May 2015 15:59:50 +0200, Quentin Lambert wrote: > > > > On 28/05/2015 15:52, Takashi Iwai wrote: > > At Thu, 28 May 2015 14:48:27 +0200, > > Quentin Lambert wrote: > >> You should use dev_groups instead of the dev_attrs field of struct > >> bus_type. This converts the MDIO bus code to use the correct field. > >> > >> These modifications were made using Coccinelle. > >> > >> Signed-off-by: Quentin Lambert > > What's wrong with dev_attrs? > > (Not offending, I'm just curious where the preference for dev_groups > > is referred...) > > This patch is based on commit 4192c74940e23da727eb02b7b4ee779dde2f670, > its message indicates that dev_attrs is going away. OK, makes sense. Then please keep such information in the changelog. BTW, the code in question isn't MDIO at all. Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into soundbus/sysfs.c, and make it this global instead of soundbus_dev_attrs[]. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Date: Thu, 28 May 2015 14:09:10 +0000 Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups Message-Id: List-Id: References: <1432817307-28380-1-git-send-email-lambert.quentin@gmail.com> <55671F56.6080402@gmail.com> In-Reply-To: <55671F56.6080402@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Quentin Lambert Cc: Johannes Berg , Jaroslav Kysela , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org At Thu, 28 May 2015 15:59:50 +0200, Quentin Lambert wrote: > > > > On 28/05/2015 15:52, Takashi Iwai wrote: > > At Thu, 28 May 2015 14:48:27 +0200, > > Quentin Lambert wrote: > >> You should use dev_groups instead of the dev_attrs field of struct > >> bus_type. This converts the MDIO bus code to use the correct field. > >> > >> These modifications were made using Coccinelle. > >> > >> Signed-off-by: Quentin Lambert > > What's wrong with dev_attrs? > > (Not offending, I'm just curious where the preference for dev_groups > > is referred...) > > This patch is based on commit 4192c74940e23da727eb02b7b4ee779dde2f670, > its message indicates that dev_attrs is going away. OK, makes sense. Then please keep such information in the changelog. BTW, the code in question isn't MDIO at all. Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into soundbus/sysfs.c, and make it this global instead of soundbus_dev_attrs[]. Takashi