From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752249Ab0IMVdi (ORCPT ); Mon, 13 Sep 2010 17:33:38 -0400 Received: from cantor.suse.de ([195.135.220.2]:33044 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821Ab0IMVdh (ORCPT ); Mon, 13 Sep 2010 17:33:37 -0400 Date: Mon, 13 Sep 2010 23:33:35 +0200 Message-ID: From: Takashi Iwai To: Joe Perches Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela , alsa-devel Subject: Re: [PATCH 24/25] sound: Use static const char arrays In-Reply-To: <1284410865.26719.88.camel@Joe-Laptop> References: <1284410865.26719.88.camel@Joe-Laptop> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 13 Sep 2010 13:47:45 -0700, Joe Perches wrote: > > On Mon, 2010-09-13 at 22:30 +0200, Takashi Iwai wrote: > > At Mon, 13 Sep 2010 12:48:02 -0700, > > Joe Perches wrote: > > > diff --git a/sound/core/misc.c b/sound/core/misc.c > > > - char tmp[] = "<0>"; > > > + char tmp[sizeof("<0>")]; > > Would this case save something really...? > > Not really. It's the same x86 code size with different opcodes. > It's just a stupid checkpatch future warning avoidance change. > Ignore it at your pleasure. OK, then let's postpone. The current code is indeed not sexy, but the patch won't improve the readability much, too ;) thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 24/25] sound: Use static const char arrays Date: Mon, 13 Sep 2010 23:33:35 +0200 Message-ID: References: <1284410865.26719.88.camel@Joe-Laptop> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 77ABD10384F for ; Mon, 13 Sep 2010 23:33:36 +0200 (CEST) In-Reply-To: <1284410865.26719.88.camel@Joe-Laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Joe Perches Cc: alsa-devel , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org At Mon, 13 Sep 2010 13:47:45 -0700, Joe Perches wrote: > > On Mon, 2010-09-13 at 22:30 +0200, Takashi Iwai wrote: > > At Mon, 13 Sep 2010 12:48:02 -0700, > > Joe Perches wrote: > > > diff --git a/sound/core/misc.c b/sound/core/misc.c > > > - char tmp[] = "<0>"; > > > + char tmp[sizeof("<0>")]; > > Would this case save something really...? > > Not really. It's the same x86 code size with different opcodes. > It's just a stupid checkpatch future warning avoidance change. > Ignore it at your pleasure. OK, then let's postpone. The current code is indeed not sexy, but the patch won't improve the readability much, too ;) thanks, Takashi