From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F033FC433F5 for ; Mon, 31 Jan 2022 08:18:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230156AbiAaISw (ORCPT ); Mon, 31 Jan 2022 03:18:52 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:43718 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbiAaISw (ORCPT ); Mon, 31 Jan 2022 03:18:52 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id EBE54212B9; Mon, 31 Jan 2022 08:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1643617130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M5ATpzd25e+Sy/RCew0oyKft2+Dk493GtVbeEoXo7c0=; b=O98YnZJulMDnlClCc7g/XuZFuDXrv8AbQ0q1flmfnHGlulJ0DN074srYGKW5g095TT3UTt /9doB+C0oQJM8+6bktFqK1HM2bdJL8zjqUjUlfsW4EsbGzqFJUT4vNJ3vLzWrDk0OUzL3n C1Lbj5an1YSMMMfhhp0a5kz9xMdPHI8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1643617130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M5ATpzd25e+Sy/RCew0oyKft2+Dk493GtVbeEoXo7c0=; b=VE6j3yVAchvW60GzVd1DoxCun9XLJHEQ5hX4TRnK5puDZEUh/33GNhVUiwe1kWhtio+ZJI adZUbRGpzFIupMBg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id AF6B9A3B85; Mon, 31 Jan 2022 08:18:50 +0000 (UTC) Date: Mon, 31 Jan 2022 09:18:50 +0100 Message-ID: From: Takashi Iwai To: Stephen Boyd Cc: Greg Kroah-Hartman , Douglas Anderson , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Jaroslav Kysela , Takashi Iwai , Kai Vehmanen , Daniel Vetter , "Rafael J. Wysocki" , Rob Clark , Russell King , Saravana Kannan Subject: Re: [PATCH v6 29/35] sound: hdac: Migrate to aggregate driver In-Reply-To: <20220127200141.1295328-30-swboyd@chromium.org> References: <20220127200141.1295328-1-swboyd@chromium.org> <20220127200141.1295328-30-swboyd@chromium.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, 27 Jan 2022 21:01:35 +0100, Stephen Boyd wrote: > > Use an aggregate driver instead of component ops so that we can get > proper driver probe ordering of the aggregate device with respect to all > the component devices that make up the aggregate device. > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Kai Vehmanen > Cc: Daniel Vetter > Cc: "Rafael J. Wysocki" > Cc: Rob Clark > Cc: Russell King > Cc: Saravana Kannan > Signed-off-by: Stephen Boyd The patch looks good, but just a minor concern: > +static struct aggregate_driver hdac_aggregate_driver = { > + .probe = hdac_component_master_bind, > + .remove = hdac_component_master_unbind, > + .driver = { > + .name = "hdac_agg", Shouldn't we define some standard name scheme? This one has "hdac_agg", while the patch for HD-audio Realtek stuff has "realtek_aggregate". (And maybe the latter one should be something like "hda_realtek_agg" or such, as Realtek covers pretty different devices and there might be conflict in future.) With those considered: please take my ack Acked-by: Takashi Iwai thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77768C433F5 for ; Mon, 31 Jan 2022 08:19:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1AB7810E3F0; Mon, 31 Jan 2022 08:18:55 +0000 (UTC) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC90610EAC4; Mon, 31 Jan 2022 08:18:52 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id EBE54212B9; Mon, 31 Jan 2022 08:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1643617130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M5ATpzd25e+Sy/RCew0oyKft2+Dk493GtVbeEoXo7c0=; b=O98YnZJulMDnlClCc7g/XuZFuDXrv8AbQ0q1flmfnHGlulJ0DN074srYGKW5g095TT3UTt /9doB+C0oQJM8+6bktFqK1HM2bdJL8zjqUjUlfsW4EsbGzqFJUT4vNJ3vLzWrDk0OUzL3n C1Lbj5an1YSMMMfhhp0a5kz9xMdPHI8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1643617130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M5ATpzd25e+Sy/RCew0oyKft2+Dk493GtVbeEoXo7c0=; b=VE6j3yVAchvW60GzVd1DoxCun9XLJHEQ5hX4TRnK5puDZEUh/33GNhVUiwe1kWhtio+ZJI adZUbRGpzFIupMBg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id AF6B9A3B85; Mon, 31 Jan 2022 08:18:50 +0000 (UTC) Date: Mon, 31 Jan 2022 09:18:50 +0100 Message-ID: From: Takashi Iwai To: Stephen Boyd Subject: Re: [PATCH v6 29/35] sound: hdac: Migrate to aggregate driver In-Reply-To: <20220127200141.1295328-30-swboyd@chromium.org> References: <20220127200141.1295328-1-swboyd@chromium.org> <20220127200141.1295328-30-swboyd@chromium.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Saravana Kannan , Kai Vehmanen , "Rafael J. Wysocki" , Greg Kroah-Hartman , Takashi Iwai , Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , linux-arm-msm@vger.kernel.org, Russell King , Jaroslav Kysela , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 27 Jan 2022 21:01:35 +0100, Stephen Boyd wrote: > > Use an aggregate driver instead of component ops so that we can get > proper driver probe ordering of the aggregate device with respect to all > the component devices that make up the aggregate device. > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Kai Vehmanen > Cc: Daniel Vetter > Cc: "Rafael J. Wysocki" > Cc: Rob Clark > Cc: Russell King > Cc: Saravana Kannan > Signed-off-by: Stephen Boyd The patch looks good, but just a minor concern: > +static struct aggregate_driver hdac_aggregate_driver = { > + .probe = hdac_component_master_bind, > + .remove = hdac_component_master_unbind, > + .driver = { > + .name = "hdac_agg", Shouldn't we define some standard name scheme? This one has "hdac_agg", while the patch for HD-audio Realtek stuff has "realtek_aggregate". (And maybe the latter one should be something like "hda_realtek_agg" or such, as Realtek covers pretty different devices and there might be conflict in future.) With those considered: please take my ack Acked-by: Takashi Iwai thanks, Takashi