From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0104C2B9F8 for ; Tue, 25 May 2021 09:19:48 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF67561431 for ; Tue, 25 May 2021 09:19:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF67561431 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 72D7516F2; Tue, 25 May 2021 11:18:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 72D7516F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621934386; bh=60RXnev2Turrg9ywKJl4qdqrtaBOEzN3PsGzhD+qb84=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=H4TeLU5NQVyBs5EqEEzRWxEd58IJCtxaA6mXeEKg/ugMjDJdPWje/bbWKSVxbKPz5 dCCsDJ5zL65wp5TYH3F1A2bxMYFhEXTe2vOBOrvjF/n8bTk3q/xms6gY3tjHxnfClM yq1gIc0rOiCxVDuG7piEvwwC1NEiVgpImiE8z/MQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0AE24F8019D; Tue, 25 May 2021 11:18:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C5B2AF801EB; Tue, 25 May 2021 11:18:54 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9795DF8011B for ; Tue, 25 May 2021 11:18:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9795DF8011B Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="spLq9+Fa"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Pmqo7W9o" X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621934325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U9XlrUest9bZgTrQc0ZMuBWhf8PnqmncgRklhQAc0nw=; b=spLq9+FaUJUQKW/5neDfw2mDrAYA9h8Uk6YrlZDBUBBcFfRpuq0qrp9k1EP+k4uBmuRZzu gdd2eajRlWhHyhSHX1S8ImpRug2Q6pPyZk/Xcz3LBGrx3MBIwQhlb9crgIg33zxmXqClZ1 K0NWLBV9m2ZIPzkS+Yqk9dphxGS8gqc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621934325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U9XlrUest9bZgTrQc0ZMuBWhf8PnqmncgRklhQAc0nw=; b=Pmqo7W9oYn47CnyqF850elptS+PyA8DA2UPaHgyaWcppehIRLFh3abxEj78WAaXcJUCGxM AzVzDnTJw8aaWLDA== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0557FAE1F; Tue, 25 May 2021 09:18:45 +0000 (UTC) Date: Tue, 25 May 2021 11:18:44 +0200 Message-ID: From: Takashi Iwai To: "Ujfalusi, Peter" Subject: Re: [PATCH] ALSA: hda: Add Lenovo ThinkStation P340 to power_save_denylist In-Reply-To: <2a2cc0cc-a7b4-9981-b463-06919ced72a8@linux.intel.com> References: <20210524152533.7479-1-peter.ujfalusi@linux.intel.com> <3e7428d2-2cfd-5835-33ef-72f3a2f43324@linux.intel.com> <2a2cc0cc-a7b4-9981-b463-06919ced72a8@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, tiwai@suse.com, kai.vehmanen@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 25 May 2021 11:04:14 +0200, Ujfalusi, Peter wrote: > > > > On 5/25/2021 11:23 AM, Takashi Iwai wrote: > >>> Let's check other possibilities > >>> at first, e.g. setting auto_mute_via_amp flag. This can be achieved > >>> even via hints in an early patching specified via "patch" option of > >>> snd-hda-intel module (see Documentation/sound/hda/notes.rst for some > >>> information). > >> > >> Unfortunately the auto_mute_via_amp has no effect on the pop. > >> line_in_auto_switch and pin_amp_workaround have no effect either. > > > > How about applying alc_fixup_no_shutup() or alc_fixup_disable_aamix()? > > it looks like > > SND_PCI_QUIRK(0x17aa, 0x1048, "Lenovo ThinkStation P340", > ALC269_FIXUP_NO_SHUTUP), > > in alc269_fixup_tbl[] > > alone fixes the pop noise, I'll send a new patch to do this instead. Good to hear. But, there is already a quirk entry for this ID, so you'll need to put a chain there instead, I suppose. Takashi