All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Cc: ALSA development <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>,
	stable@kernel.org
Subject: Re: [PATCH] ASoC: AMD Renoir - add DMI table to avoid the ACP mic probe (broken BIOS)
Date: Tue, 08 Dec 2020 18:57:39 +0100	[thread overview]
Message-ID: <s5htuswuqng.wl-tiwai@suse.de> (raw)
In-Reply-To: <2e4587f8-f602-cf23-4845-fd27a32b1cfc@amd.com>

On Tue, 08 Dec 2020 19:06:21 +0100,
Mukunda,Vijendar wrote:
> 
> 
> 
> On 08/12/20 11:10 pm, Mark Brown wrote:
> > On Tue, Dec 08, 2020 at 05:24:32PM +0100, Takashi Iwai wrote:
> >
> >> BTW, both Raven and Reonir drivers point to the very same PCI ID,
> >> and both drivers will be probed for this machine (and both to be
> >> skipped).
> >
> > Ugh, that's not good.  It's not even super obvious from the code that
> > this is happening.  Seems like it should be one core driver which
> > instantiates the components for Raven and Reonir as appropriate, the PCI
> > driver is pretty thin at present anyway.
> >
> 
> Raven and Renoir has same PCI ID but both platforms have different
> revision ID. Raven platform revision id is 0x00 where as for Renoir it
> is 0x01.

But your drivers don't check the revision ID, as far as I see?

The linux PCI driver doesn't distinguish the revision id at the
matching time, unfortunately.


Takashi

  parent reply	other threads:[~2020-12-08 17:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 15:36 [PATCH] ASoC: AMD Renoir - add DMI table to avoid the ACP mic probe (broken BIOS) Jaroslav Kysela
2020-12-08 16:24 ` Takashi Iwai
2020-12-08 17:15   ` Jaroslav Kysela
2020-12-08 17:40   ` Mark Brown
2020-12-08 18:06     ` Mukunda,Vijendar
2020-12-08 17:55       ` Jaroslav Kysela
2020-12-08 17:57       ` Takashi Iwai [this message]
2020-12-08 18:21         ` Mukunda,Vijendar
2020-12-08 18:23           ` Mukunda,Vijendar
2020-12-08 18:14             ` Jaroslav Kysela
2020-12-08 18:39               ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5htuswuqng.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=stable@kernel.org \
    --cc=vijendar.mukunda@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.