From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v5 0/4] Propagate errors out from compressed streams Date: Wed, 20 Apr 2016 15:09:30 +0200 Message-ID: References: <1461156003-24422-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id B0199266558 for ; Wed, 20 Apr 2016 15:09:31 +0200 (CEST) In-Reply-To: <1461156003-24422-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Charles Keepax Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com, patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Wed, 20 Apr 2016 14:39:59 +0200, Charles Keepax wrote: > > If the DSP suffers an unrecoverable error, the driver likely > knows about this, however the framework may not get informed > because errors returned from pointer requests are ignored within > the framework. > > Things work out fine if user-space is doing a read as reads > return error status back to user-space so the user can find out > that things have gone bad. However, if user-space is doing an > avail request there is no path for the error to come back up to > user-space. The pointer request returns zero available data, so a > read never happens and we basically just end up sitting waiting > for data on a stream that we know full well has died. > > This patch set attempts to address this and ensure that errors > are fully propagated to user-space and we don't ever end up wait > for data that will never come. > > Changes since v4: > - Fix issue noticed by Vinod whereby the error state was being > overwritten when snd_compr_stop was called > > It might be easiest to put the ASoC changes through Mark's tree > as there are some merge conflicts otherwise, as such I have based > this series on Mark's tree. If it goes through Mark's tree, feel free to take my ack to these patches: Acked-by: Takashi Iwai Or if it's easier through my tree, let me know. thanks, Takashi