From: Takashi Iwai <tiwai@suse.de>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH] drm/i915: Don't write DSPSURF for old chips
Date: Mon, 27 Feb 2012 12:39:24 +0100 [thread overview]
Message-ID: <s5hty2csdxv.wl%tiwai@suse.de> (raw)
It seems that writing DSPSURF in intel_flush_display_plane() causes
the blank screen on some old laptops like Dell D630 with 965GM.
Since this operation is needed only for ILK+, make it conditional.
Cc: <stable@kernel.org> [v3.1+]
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
drivers/gpu/drm/i915/intel_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1379,7 +1379,8 @@ static void intel_flush_display_plane(st
enum plane plane)
{
I915_WRITE(DSPADDR(plane), I915_READ(DSPADDR(plane)));
- I915_WRITE(DSPSURF(plane), I915_READ(DSPSURF(plane)));
+ if (dev_priv->info->gen >= 5)
+ I915_WRITE(DSPSURF(plane), I915_READ(DSPSURF(plane)));
}
/**
next reply other threads:[~2012-02-27 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 11:39 Takashi Iwai [this message]
2012-02-27 12:17 ` [PATCH] drm/i915: Don't write DSPSURF for old chips Chris Wilson
2012-02-27 13:08 ` Takashi Iwai
2012-02-28 6:43 ` Takashi Iwai
2012-02-29 23:54 ` Chris Wilson
2012-03-01 6:37 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hty2csdxv.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.