From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] Replace libsamplerate resampler with libavcodec Date: Mon, 19 Feb 2007 12:12:05 +0100 Message-ID: References: <20070219060932.GA24147@kain.us> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Nicholas Kain Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Mon, 19 Feb 2007 01:14:11 -0500, Nicholas Kain wrote: > > libsamplerate does a nice job of upsampling audio while retaining quality, but > is rather inefficient and is GPL-licensed. libavcodec includes a resampler of > equivalent quality that is about an order of magnitude faster in my tests. > > ALSA is already using libavcodec for its a52 plugin, but it is important to > note that the a52 code in libavcodec is one of a few parts in lavc that is > licensed under the GPL. The resampling code is LGPL licensed, so it's > available under much more flexible terms. > > I've written a patch that replaces the use of libsamplerate with libavcodec's > resampler. It is currently a drop-in replacement that uses the exact same > interfaces and dynamically links to libavcodec. It is easily possible to pull > the LGPL resampling code out of libavcodec and include it directly with the > plugin if that is desirable -- it would not require invasive modifications -- > but I have not done so yet. IMO, we should _add_ libavcodec resampler plugin instead of replacing the libsamplerate one. From the license POV, libavcodec is fairly grey, and it's very unlikely bundled in most of linux distributions. So, could you change your patch to add a new subdirectory and plugin? We have already HAVE_AVCODEC conditional in configure script, hence the addition would be pretty simple. Thanks, Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV