From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39D7DC433EF for ; Tue, 7 Dec 2021 08:08:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 722C02393; Tue, 7 Dec 2021 09:07:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 722C02393 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1638864505; bh=1yMHsnh5Gskta62Pbpk+W8UkfQPLEDDGfCZtlcAdOro=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=F/op7ouixnTYmUpC9MaOCA7SGT6DWiKiOhYxhZRjmMXoXkKkbIWZM0Ygc1ApXGZHf Qjq2LkMXsPMR+52LqqJ3doq+npbfqDo8kh+UO5MUsq2oqY1bvLHN47ExZNI9LA4nAM t5Y2W4OddKLDeoX0+JciPtK0thWTKNUDUjEeEoHM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7DF48F8028D; Tue, 7 Dec 2021 09:07:29 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C07D3F80253; Tue, 7 Dec 2021 09:07:28 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 73C61F80253 for ; Tue, 7 Dec 2021 09:07:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 73C61F80253 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Fc758gQu"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="tlyEB9Hg" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 4CFC51FD2F; Tue, 7 Dec 2021 08:07:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638864444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=il5a5JJR0ZfdJ2jUiyG6AT13ksKGx4mpOYxIh/QTUOw=; b=Fc758gQu1PbHz5/6ZwWbiBmSJizg5xxDlljPRYgY9odWMgaVzmRTdAi47e+nN/0exejH7t B9OT6agT5XkRrcdS2z0RXQ6Dnr4mwnEqHuTuk8IX1+6FPdcpUBsdQAT2W8Nm0dswdM3NwV 0+DRbmyZTjA9QON8lJA6Fxwe1B3pDY4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638864444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=il5a5JJR0ZfdJ2jUiyG6AT13ksKGx4mpOYxIh/QTUOw=; b=tlyEB9HgvbkMTNO+h1lMI3+ifDq0icWHlwsWr63x9yxiifTdrFKlt/SRDsgEkmdp/Mv09G wujrBT1jvmACA8Bg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 46886A3B8A; Tue, 7 Dec 2021 08:07:24 +0000 (UTC) Date: Tue, 07 Dec 2021 09:07:24 +0100 Message-ID: From: Takashi Iwai To: Hans de Goede Subject: Re: Logitech Z10 USB speakers need a volume change before audio works In-Reply-To: References: <7f36906e-fd4b-c14e-4189-0d8b7de271ac@redhat.com> <2af48c9f-60d7-ed63-845d-9adb8cb7b037@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: "alsa-devel@alsa-project.org" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 06 Dec 2021 14:54:08 +0100, Hans de Goede wrote: > > Hi Takashi, > > On 12/2/21 09:25, Takashi Iwai wrote: > > On Wed, 01 Dec 2021 16:44:11 +0100, > > Hans de Goede wrote: > >> > >> Hi, > >> > >> On 11/30/21 16:56, Takashi Iwai wrote: > >>> On Tue, 30 Nov 2021 15:33:35 +0100, > >>> Hans de Goede wrote: > >>>> > >>>> Hi, > >>>> > >>>> On 11/30/21 12:07, Hans de Goede wrote: > >>>>> Hi, > >>>>> > >>>>> On 11/25/21 13:42, Takashi Iwai wrote: > >>>>>> On Thu, 25 Nov 2021 12:04:41 +0100, > >>>>>> Hans de Goede wrote: > >>>>>>> > >>>>>>> Hi, > >>>>>>> > >>>>>>> I've a set of Logitech Z10 USB speakers, which act as a USB soundcard. > >>>>>>> > >>>>>>> They have this weird glitch where after turning off my PC (and their > >>>>>>> power-supply as well) and then turning things back on, they are silent > >>>>>>> until I change the PCM volume control for the speakers inside > >>>>>>> alsa-mixer. > >>>>>>> > >>>>>>> It seems like they need some "set-volume" command to be send over the > >>>>>>> USB bus to unmute them when initially powered-up / turned on. > >>>>>>> > >>>>>>> Is their some existing usb-audio quirk which I can try to work around this? > >>>>>> > >>>>>> No such quirk is present for now. > >>>>>> > >>>>>> Was it tested with 5.16-rc? There was a change in USB-audio driver > >>>>>> initialization (commit b96681bd5827) and it might have some effect in > >>>>>> your case. > >>>>> > >>>>> Yes I'm at 5.16-rc3 atm but I've been seeing this for quite some time. > >>>>> I just never got around to reporting it. Mainly because I also never > >>>>> got around to getting a bit clearer picture of the problem. > >>>>> > >>>>> I've spend some time this morning to get that clearer picture, > >>>>> which was insightful. > >>>>> > >>>>>> Also, it's interesting to know whether it happens also once after > >>>>>> suspend-resume, too. > >>>>> > >>>>> suspend-resume makes no difference, not even rebooting or > >>>>> powering off the machine makes a difference. > >>>>> > >>>>> Once the speakers are in working order they stay in working order > >>>>> until I turn off my machine; and then flick the power-switch on > >>>>> the 240V AC power-bar which I use to power my laptop + dock + > >>>>> monitors + the speakers and turn things back on the next morning. > >>>>> > >>>>> To be clear these speakers get their audio-data over USB > >>>>> (as an usb-audio device) but they have their own power-supply > >>>>> they are not USB powered. They also have a "soft" on/off button > >>>>> which turns on/off the amplifier and LCD screen parts but leaves > >>>>> the USB audio interface active. > >>>>> > >>>>> So I've been experimenting with reproducing the issue and I > >>>>> need to do the following minimal steps to reproduce: > >>>>> > >>>>> 1. Unplug USB > >>>>> 2. Unplug power > >>>>> 3. Re-plug power > >>>>> 4. Re-plug USB > >>>>> 5. speaker-test -Dfront:CARD=Speaker,DEV=0 -S1 > >>>>> 6. Turn speakers on (with the on/off button on the speakers), no audio > >>>>> > >>>>> 5 and 6 may be swapped, same result > >>>>> > >>>>> And now that I have a reliable reproducer I've also been > >>>>> playing with a reliable workaround which looks like this: > >>>>> > >>>>> 1. Start playing audio to the speakers > >>>>> 2. Turn speakers on (with the on/off button on the speakers) > >>>>> 3. Make a change to the 'PCM Playback Volume' ctrl > >>>>> > >>>>> Where 1. and 2. may be swapped. But the > >>>>> 'PCM Playback Volume' ctrl change must be made while the > >>>>> speakers are on and playing audio ! > >>>>> > >>>>> Although I have found that this also works: > >>>>> > >>>>> 1. Start playing audio to the speakers > >>>>> 2. Turn speakers on (with the on/off button on the speakers) > >>>>> 3. Stop playing audio > >>>>> 4. Make a change to the 'PCM Playback Volume' ctrl > >>>>> 5. Start playing audio to the speakers again > >>>>> > >>>>> I then even here a brief "power-up buzz" coming from the > >>>>> speakers at 4. > >>>>> > >>>>> And this sequence also works: > >>>>> > >>>>> 1. Start playing audio to the speakers > >>>>> 2. Stop playing audio > >>>>> 3. Turn speakers on (with the on/off button on the speakers) > >>>>> 4. Make a change to the 'PCM Playback Volume' ctrl > >>>>> 5. Start playing audio to the speakers again > >>>>> > >>>>> So it seems that to work (after having been unplugged > >>>>> form the mains) these speakers need to: > >>>>> > >>>>> 1. Have had some audio send to them at least once > >>>>> 2. After this have their 'PCM Playback Volume' ctrl poked > >>>>> at once while they are on (and if they are on cannot > >>>>> be seen from the PC side AFAICT). > >>>>> > >>>>> Note instead of changing the 'PCM Playback Volume' ctrl > >>>>> toggling the associated mute ctrl works too. > >>>>> > >>>>> TL;DR: Since getting the speakers to work involves > >>>>> setting a ctrl while they are on, which is something > >>>>> which we cannot tell from the kernel side I don't believe > >>>>> that there is anything we can do about this from within > >>>>> the kernel. > >>>> > >>>> So thinking more about this I guess we could do something > >>>> where we resend the last PCM volume to the device every > >>>> 5 seconds *when the device is playing audio*, assuming that > >>>> the resending of the same PCM volume is sufficient to fix > >>>> things. > >>>> > >>>> These are pretty nice speakers so getting them to work without > >>>> this glitch would be nice. But it would require a significant > >>>> bit of (quirk enabled) code just for this 1 model speakers. > >>>> > >>>> Takashi, what do you think. Should I give the resend volume > >>>> once every 5 seconds idea a try, or is it likely going to > >>>> end up being too ugly to merge ? > >>> > >>> It sounds too hackish and fragile to me... > >> > >> Yes, I agree, > >> > >>> Do we need to repeat each > >>> 5 seconds? Wouldn't it suffice to touch only once at setting up the > >>> stream (or need before or after the stream start), instead? > >> > >> The problem is that at least with my testing with alsamixer + speaker-test > >> I need to make the PCM ctl change when the speakers are on. > >> > >> And I often find myself doing the following: > >> > >> 1. Start something which requires working audio > >> 2. Oh wait, the speakers are off, turn them on > >> > >> At which point if we do this at stream-start this would require > >> a pause + unpause. At which point just hitting volume up + down > >> hotkeys is just as easy (easier even when in say a video-conf-call). > >> > >> So I believe my time is better spend to track down the pipewire > >> regression where newer pipewire versions no longer use hw-volume-ctrl > >> on these speakers for some reason. Fixing that will restore my old > >> workaround and will hopefully also help other users. > >> > >> I guess this is mostly an issue for me because I turn of the > >> mains power to the speakers every evening, other users just > >> need to fiddle with the volume once and then things will work > >> until the speakers get unplugged from the mains. > >> > >>> In anyway, alsa-info.sh output would be helpful. > >> > >> Sure here you go: > >> http://alsa-project.org/db/?f=8b93e72b6fb4be5c426eade5f78ed58137bdf0ef' > >> > >> Note there are quite a few audio devices in my setup: > >> > >> 1. My X1 carbon laptop's builtin sound > >> 2. The Thunderbolt docks' USB audio (unused) > >> 3. A TI USB audio codec going to the receiver connected to > >> my proper/real speakers for listening music > >> 4. The Logitech Z-10 speakers which we are discussing here > >> > >> Anyway, not sure if this is worth spending much (more) time on > >> but if you have some idea for me to test, let me know. > > > > Below is a quick hack, let's see whether this kind of change is > > enough for this device. > > > > > > Takashi > > > > --- a/sound/usb/quirks.c > > +++ b/sound/usb/quirks.c > > @@ -1280,6 +1280,15 @@ int snd_usb_apply_interface_quirk(struct snd_usb_audio *chip, > > int iface, > > int altno) > > { > > +#ifdef CONFIG_PM > > + if (chip->usb_id == USB_ID(0x046d, 0x0a07)) { > > + struct usb_mixer_interface *mixer; > > + list_for_each_entry(mixer, &chip->mixer_list, list) > > + snd_usb_mixer_resume(mixer); > > + return 0; > > + } > > +#endif > > + > > /* audiophile usb: skip altsets incompatible with device_setup */ > > if (chip->usb_id == USB_ID(0x0763, 0x2003)) > > return audiophile_skip_setting_quirk(chip, iface, altno); > > > > Thanks, unfortunately this does not make any difference. OK, then it's not that straightforward :-< Takashi