From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755037AbaHEPxy (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Aug 2014 11:53:54 -0400
Received: from cantor2.suse.de ([195.135.220.15]:51956 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753119AbaHEPxw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Aug 2014 11:53:52 -0400
Date: Tue, 05 Aug 2014 17:53:49 +0200
Message-ID: <s5hvbq753w2.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Jean-Michel Hautbois <jhautbois@gmail.com>
Cc: B_B_Singh@dell.com, Greg KH <gregkh@linuxfoundation.org>,
        Abhay_Salunke@dell.com, Arnd Bergmann <arnd@arndb.de>, kay@vrfy.org,
        ming.lei@canonical.com, Stefan Roese <sr@denx.de>, teg@jklm.no,
        Stuart_Hayes@dell.com, Srinivas_G_Gowda@dell.com,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: patch "firmware loader: allow disabling of udev as firmware loader" added to driver-core tree
In-Reply-To: <CAL8zT=jDUyxjimFxBFk56q+B9VwZdnijrU9VF7LBm4X4mNKp+g@mail.gmail.com>
References: <14048583172593@kroah.com>
	<8B2F6FFD0BD1E448853114367400A37306FD6FBBE9@BLRX7MCDC203.AMER.DELL.COM>
	<s5h38e9mg5v.wl%tiwai@suse.de>
	<8B2F6FFD0BD1E448853114367400A37306FD6FBBF8@BLRX7MCDC203.AMER.DELL.COM>
	<s5hy4w1l0s3.wl%tiwai@suse.de>
	<8B2F6FFD0BD1E448853114367400A37306FD6FBC06@BLRX7MCDC203.AMER.DELL.COM>
	<s5hpphdkyi6.wl%tiwai@suse.de>
	<8B2F6FFD0BD1E448853114367400A37306FD6FBDAB@BLRX7MCDC203.AMER.DELL.COM>
	<s5hoawvkimg.wl%tiwai@suse.de>
	<8B2F6FFD0BD1E448853114367400A37306FE07C773@BLRX7MCDC203.AMER.DELL.COM>
	<s5h7g3frmg7.wl%tiwai@suse.de>
	<8B2F6FFD0BD1E448853114367400A37306FE07CC64@BLRX7MCDC203.AMER.DELL.COM>
	<s5hlhrrizbq.wl%tiwai@suse.de>
	<8B2F6FFD0BD1E448853114367400A37306FE311D74@BLRX7MCDC203.AMER.DELL.COM>
	<CAL8zT=jDUyxjimFxBFk56q+B9VwZdnijrU9VF7LBm4X4mNKp+g@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Tue, 5 Aug 2014 17:43:17 +0200,
Jean-Michel Hautbois wrote:
> 
> 2014-08-01 22:01 GMT+02:00  <B_B_Singh@dell.com>:
> > Hi Takashi,
> >
> > Sorry for the late response,  I tried with latest stable kernel 3.15.8.  surprisingly the BIOS update works even without applying the patch in both the cases.
> 
> Hi,I'm sorry for my late answer too, but I didn't try this patch recently...
> 
> I have a Lattice FPGA on my board, and it seems that your patch breaks
> the firmware loading.
> I have the following config :
> CONFIG_FW_LOADER=y
> CONFIG_FW_LOADER_USER_HELPER=n
> FW_LOADER_USER_HELPER_FALLBACK=n
> LATTICE_ECP3_CONFIG=y

It worked before applying my patch properly...?

The kernel Oops itself is a bug in lattice-ecp3-config driver.
It blindly assumes that the returned firmware is non-NULL.
firmware_load() must have a NULL check of fw at the beginning.


thanks,

Takashi