From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44013C4338F for ; Sun, 25 Jul 2021 07:44:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C7FD60E0C for ; Sun, 25 Jul 2021 07:44:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230226AbhGYHDq (ORCPT ); Sun, 25 Jul 2021 03:03:46 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:35704 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229883AbhGYHDc (ORCPT ); Sun, 25 Jul 2021 03:03:32 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 688B321FE7; Sun, 25 Jul 2021 07:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627199041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uTdCr90EhfYnVuvMUH866bNjY+DJx+dcPV6cBpY0faA=; b=JR7YVXuM1KyXY9KsF7olywfQ42lvfjVIQ3rHJlj6rnRT1X8Cp6FkRYAKPKzipr2026307J UchhKdD28lxNGgMvm75l0ckPIGmxcyJfAwyHnG5NFIw3BnE3IvsqmKYLmYcMuDT64gNPE0 UPzrvOmTeZy/gTY9Sm7sxbwjIYKzJKQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627199041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uTdCr90EhfYnVuvMUH866bNjY+DJx+dcPV6cBpY0faA=; b=bqh8bugg/inwtUvpftZtGto0o7dU9nbda8gUGpA4YRgoQSDW0Px0JTiFPUDZpT/+FoCTYs v4i0H0vzna/4f1Dg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 3B937A3B83; Sun, 25 Jul 2021 07:44:01 +0000 (UTC) Date: Sun, 25 Jul 2021 09:44:01 +0200 Message-ID: From: Takashi Iwai To: Geraldo Nascimento Cc: chihhao.chen@mediatek.com, alsa-devel@alsa-project.org, wsd_upstream@mediatek.com, damien@zamaudio.com, tiwai@suse.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting In-Reply-To: References: <1627100621-19225-1-git-send-email-chihhao.chen@mediatek.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 24 Jul 2021 17:04:13 +0200, Geraldo Nascimento wrote: > > On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai wrote: > > > > This looks like a regression introduced by the recent commit > > d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock > > selector"), which is a fix for certain devices. Too bad that the > > behavior really depends on the device... > > Dr. Iwai, perhaps we could restrict the generalized fix for the > Behringer UFX1604 / UFX1204 with some simple logic to devices that > only have *one* clock source. > > In that case the clock selector must be set to the only clock source. > > This way we keep the generalization without breaking devices with more > than one clock source. > > Just an idea. I don't think it's easy to generalize. All those bugs are more or less BIOS bugs, and a logic doesn't apply always, just because it's a bug :) For example, setting the clock selector itself should be a valid operation from the specification POV, while this leads to breakage on some devices. So, even if we add a more generic workaround, we need to see which side effect is more commonly seen at first. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93428C4338F for ; Sun, 25 Jul 2021 07:45:12 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E4DD60F13 for ; Sun, 25 Jul 2021 07:45:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1E4DD60F13 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 128B71740; Sun, 25 Jul 2021 09:44:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 128B71740 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1627199109; bh=Mt5qcVD+0ZP9D7xmdA1qdExLXQwxLEWv6P3pevc9YVc=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BgG0n2gzS1dP4DgvR1SSYcMMp+4RNyUoNcyu25YVvQuhCrE73B/zP+/brI2feV8wN fsyL/wMWanR9tuMRWJh0IYhcpyGoUlsIJIEp7dlkDnE7SX23xhJUd8YGgFQgHHK1vn TylsR9RjLLI2AQSN52+cxjxKISx9eZLEvQ2L5cec= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9157EF80132; Sun, 25 Jul 2021 09:44:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8FB64F8026C; Sun, 25 Jul 2021 09:44:15 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 68BFAF80132 for ; Sun, 25 Jul 2021 09:44:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 68BFAF80132 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="JR7YVXuM"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="bqh8bugg" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 688B321FE7; Sun, 25 Jul 2021 07:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627199041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uTdCr90EhfYnVuvMUH866bNjY+DJx+dcPV6cBpY0faA=; b=JR7YVXuM1KyXY9KsF7olywfQ42lvfjVIQ3rHJlj6rnRT1X8Cp6FkRYAKPKzipr2026307J UchhKdD28lxNGgMvm75l0ckPIGmxcyJfAwyHnG5NFIw3BnE3IvsqmKYLmYcMuDT64gNPE0 UPzrvOmTeZy/gTY9Sm7sxbwjIYKzJKQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627199041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uTdCr90EhfYnVuvMUH866bNjY+DJx+dcPV6cBpY0faA=; b=bqh8bugg/inwtUvpftZtGto0o7dU9nbda8gUGpA4YRgoQSDW0Px0JTiFPUDZpT/+FoCTYs v4i0H0vzna/4f1Dg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 3B937A3B83; Sun, 25 Jul 2021 07:44:01 +0000 (UTC) Date: Sun, 25 Jul 2021 09:44:01 +0200 Message-ID: From: Takashi Iwai To: Geraldo Nascimento Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting In-Reply-To: References: <1627100621-19225-1-git-send-email-chihhao.chen@mediatek.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, wsd_upstream@mediatek.com, damien@zamaudio.com, linux-kernel@vger.kernel.org, tiwai@suse.com, chihhao.chen@mediatek.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 24 Jul 2021 17:04:13 +0200, Geraldo Nascimento wrote: > > On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai wrote: > > > > This looks like a regression introduced by the recent commit > > d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock > > selector"), which is a fix for certain devices. Too bad that the > > behavior really depends on the device... > > Dr. Iwai, perhaps we could restrict the generalized fix for the > Behringer UFX1604 / UFX1204 with some simple logic to devices that > only have *one* clock source. > > In that case the clock selector must be set to the only clock source. > > This way we keep the generalization without breaking devices with more > than one clock source. > > Just an idea. I don't think it's easy to generalize. All those bugs are more or less BIOS bugs, and a logic doesn't apply always, just because it's a bug :) For example, setting the clock selector itself should be a valid operation from the specification POV, while this leads to breakage on some devices. So, even if we add a more generic workaround, we need to see which side effect is more commonly seen at first. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D086C4338F for ; Sun, 25 Jul 2021 07:44:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0DF060F13 for ; Sun, 25 Jul 2021 07:44:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F0DF060F13 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TxYgsGF2FED3BcXqDSkxQEewk3c8iwar+MYsSxya/dc=; b=dPy2Ts4SxAnOQj exrHZP/ldQlwtFulAW6k7qBJkkk2IoZuXEsUPDxlYTucfLvrh4LuO0MhLhaWdje+BI0k7rI+oBWrs 9fsCTX9KuCJEV2DRvhssHxZRCI5sznBdyCA5qauAXNwvbeQko5N4uA5wgoFncO3pFFmqoaMdTcrbn NfEgLEpUXKDBLB78bhKGfa8y9dKtPbZ3HqP/+BWUowfUsWSoOl/3KMELc7dAc97Pz8Gq713aiN3pk VBWU+8Nu2ZIXincjtBBUZ/5kenykXwDEJ5ejJUrbf496e0tq/DOKnni07Chd7DBB79nGKvY+Z0pu1 gwnWSkejhfORPSQKwwvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7Yo4-008Mey-QP; Sun, 25 Jul 2021 07:44:16 +0000 Received: from smtp-out1.suse.de ([195.135.220.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7Ynr-008Mdr-Bn; Sun, 25 Jul 2021 07:44:04 +0000 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 688B321FE7; Sun, 25 Jul 2021 07:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627199041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uTdCr90EhfYnVuvMUH866bNjY+DJx+dcPV6cBpY0faA=; b=JR7YVXuM1KyXY9KsF7olywfQ42lvfjVIQ3rHJlj6rnRT1X8Cp6FkRYAKPKzipr2026307J UchhKdD28lxNGgMvm75l0ckPIGmxcyJfAwyHnG5NFIw3BnE3IvsqmKYLmYcMuDT64gNPE0 UPzrvOmTeZy/gTY9Sm7sxbwjIYKzJKQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627199041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uTdCr90EhfYnVuvMUH866bNjY+DJx+dcPV6cBpY0faA=; b=bqh8bugg/inwtUvpftZtGto0o7dU9nbda8gUGpA4YRgoQSDW0Px0JTiFPUDZpT/+FoCTYs v4i0H0vzna/4f1Dg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 3B937A3B83; Sun, 25 Jul 2021 07:44:01 +0000 (UTC) Date: Sun, 25 Jul 2021 09:44:01 +0200 Message-ID: From: Takashi Iwai To: Geraldo Nascimento Cc: chihhao.chen@mediatek.com, alsa-devel@alsa-project.org, wsd_upstream@mediatek.com, damien@zamaudio.com, tiwai@suse.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting In-Reply-To: References: <1627100621-19225-1-git-send-email-chihhao.chen@mediatek.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210725_004403_611582_07C2882A X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sat, 24 Jul 2021 17:04:13 +0200, Geraldo Nascimento wrote: > > On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai wrote: > > > > This looks like a regression introduced by the recent commit > > d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock > > selector"), which is a fix for certain devices. Too bad that the > > behavior really depends on the device... > > Dr. Iwai, perhaps we could restrict the generalized fix for the > Behringer UFX1604 / UFX1204 with some simple logic to devices that > only have *one* clock source. > > In that case the clock selector must be set to the only clock source. > > This way we keep the generalization without breaking devices with more > than one clock source. > > Just an idea. I don't think it's easy to generalize. All those bugs are more or less BIOS bugs, and a logic doesn't apply always, just because it's a bug :) For example, setting the clock selector itself should be a valid operation from the specification POV, while this leads to breakage on some devices. So, even if we add a more generic workaround, we need to see which side effect is more commonly seen at first. Takashi _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01FE9C4338F for ; Sun, 25 Jul 2021 07:49:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B626660F13 for ; Sun, 25 Jul 2021 07:49:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B626660F13 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mBvCHG3NY10nidLkG6HxKha36nYYDnlifUcH17p9Z2o=; b=XP6oDExVV9ZON2 Yo1JUDoBT4khG5FDTZn8EjMRBSmo2EmskVoGtkbfrc2Piw1KoBmoySua8eTTJJFzPbJPqPGc3ajuP G5v8w2FKj9J8/eGWO+vcZdRsro8w0yFpuxmlxxsdMg3Q2I7Hjc+28x1ByYLeP87hd3ltN2RvOJBXv baWZPG3NNt/Pk2W2tvW64lyexnepDWsCK97z/mV+IWjfanXPaSU9KZ6VwZ+wmZaBFtlj07r+zPiE6 6kWtm8aqp+0pSCnRCY4HTLUUnJ72jhJuVnQ9n0W8QxRP0f/Wki4Ju2B1J968bATg5eNxTcSYhw+cv k6MW5rdjBjdU6KU35rWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7Ynv-008Mek-LL; Sun, 25 Jul 2021 07:44:07 +0000 Received: from smtp-out1.suse.de ([195.135.220.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7Ynr-008Mdr-Bn; Sun, 25 Jul 2021 07:44:04 +0000 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 688B321FE7; Sun, 25 Jul 2021 07:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627199041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uTdCr90EhfYnVuvMUH866bNjY+DJx+dcPV6cBpY0faA=; b=JR7YVXuM1KyXY9KsF7olywfQ42lvfjVIQ3rHJlj6rnRT1X8Cp6FkRYAKPKzipr2026307J UchhKdD28lxNGgMvm75l0ckPIGmxcyJfAwyHnG5NFIw3BnE3IvsqmKYLmYcMuDT64gNPE0 UPzrvOmTeZy/gTY9Sm7sxbwjIYKzJKQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627199041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uTdCr90EhfYnVuvMUH866bNjY+DJx+dcPV6cBpY0faA=; b=bqh8bugg/inwtUvpftZtGto0o7dU9nbda8gUGpA4YRgoQSDW0Px0JTiFPUDZpT/+FoCTYs v4i0H0vzna/4f1Dg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 3B937A3B83; Sun, 25 Jul 2021 07:44:01 +0000 (UTC) Date: Sun, 25 Jul 2021 09:44:01 +0200 Message-ID: From: Takashi Iwai To: Geraldo Nascimento Cc: chihhao.chen@mediatek.com, alsa-devel@alsa-project.org, wsd_upstream@mediatek.com, damien@zamaudio.com, tiwai@suse.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting In-Reply-To: References: <1627100621-19225-1-git-send-email-chihhao.chen@mediatek.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210725_004403_611582_07C2882A X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 24 Jul 2021 17:04:13 +0200, Geraldo Nascimento wrote: > > On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai wrote: > > > > This looks like a regression introduced by the recent commit > > d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock > > selector"), which is a fix for certain devices. Too bad that the > > behavior really depends on the device... > > Dr. Iwai, perhaps we could restrict the generalized fix for the > Behringer UFX1604 / UFX1204 with some simple logic to devices that > only have *one* clock source. > > In that case the clock selector must be set to the only clock source. > > This way we keep the generalization without breaking devices with more > than one clock source. > > Just an idea. I don't think it's easy to generalize. All those bugs are more or less BIOS bugs, and a logic doesn't apply always, just because it's a bug :) For example, setting the clock selector itself should be a valid operation from the specification POV, while this leads to breakage on some devices. So, even if we add a more generic workaround, we need to see which side effect is more commonly seen at first. Takashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel