From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EC0DC433DB for ; Sun, 27 Dec 2020 08:38:25 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD2A6221F5 for ; Sun, 27 Dec 2020 08:38:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD2A6221F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D5B63175A; Sun, 27 Dec 2020 09:37:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D5B63175A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1609058302; bh=aDJrPjABdwWWUvB6LCCz3wjzeqRQp08wdUifWQZ1GZA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WP5t21h5n6+1UAfgGllWHiLSuAHxXYax3PxoM0rCHVDuxpSAixTqaf6ZXURe+v6fb mbIb7Ae9/plpFCi65PpGBoQ3AJM6cc/AdyF8qLRGhCYb8WXdTU5VXU3jcXTnZ/NdDq sVSXuh58FmoNpTbkq9V65m6YEqEQ5+k5Y/+Gyw1Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 70ECFF8020C; Sun, 27 Dec 2020 09:37:32 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 727EBF8022B; Sun, 27 Dec 2020 09:37:30 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 15051F800C8 for ; Sun, 27 Dec 2020 09:37:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 15051F800C8 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C7F90AD75; Sun, 27 Dec 2020 08:37:27 +0000 (UTC) Date: Sun, 27 Dec 2020 09:37:27 +0100 Message-ID: From: Takashi Iwai To: Alex Henrie Subject: Re: [PATCH 9/9] conf: remove dead code from get_hexachar In-Reply-To: <20201226213547.175071-10-alexhenrie24@gmail.com> References: <20201226213547.175071-1-alexhenrie24@gmail.com> <20201226213547.175071-10-alexhenrie24@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 26 Dec 2020 22:35:47 +0100, Alex Henrie wrote: > > Signed-off-by: Alex Henrie > --- > src/conf.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/src/conf.c b/src/conf.c > index 44d1bfde..970ad643 100644 > --- a/src/conf.c > +++ b/src/conf.c > @@ -877,16 +877,9 @@ static int get_nonwhite(input_t *input) > > static inline int get_hexachar(input_t *input) > { > - int c, num = 0; > - > + int c; > c = get_char(input); > - if (c >= '0' && c <= '9') num |= (c - '0') << 4; > - else if (c >= 'a' && c <= 'f') num |= (c - 'a') << 4; > - else if (c >= 'A' && c <= 'F') num |= (c - 'A') << 4; > c = get_char(input); > - if (c >= '0' && c <= '9') num |= (c - '0') << 0; > - else if (c >= 'a' && c <= 'f') num |= (c - 'a') << 0; > - else if (c >= 'A' && c <= 'F') num |= (c - 'A') << 0; > return c; The current code is obviously wrong and the suggested fix goes even to a wronger direction :) The function should return num instead. I wonder how this did't hit any problem, so far. Maybe 0x prefix was rarely used, fortunately. thanks, Takashi