From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E33A9C43441 for ; Tue, 27 Nov 2018 11:02:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B21E32086B for ; Tue, 27 Nov 2018 11:02:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B21E32086B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731001AbeK0WAN (ORCPT ); Tue, 27 Nov 2018 17:00:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:35028 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726476AbeK0WAN (ORCPT ); Tue, 27 Nov 2018 17:00:13 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D3885AE60; Tue, 27 Nov 2018 11:02:39 +0000 (UTC) Date: Tue, 27 Nov 2018 12:02:39 +0100 Message-ID: From: Takashi Iwai To: "Ayman Bagabas" Cc: , "Hui Wang" , "Andy Shevchenko" , "Darren Hart" , "Jaroslav Kysela" , "Kailang Yang" , , Subject: Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys. In-Reply-To: <20181127025752.6459-3-ayman.bagabas@gmail.com> References: <20181127025752.6459-1-ayman.bagabas@gmail.com> <20181127025752.6459-3-ayman.bagabas@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some more forgotten bits... On Tue, 27 Nov 2018 03:57:48 +0100, Ayman Bagabas wrote: > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig .... > +config HUAWEI_WMI > + tristate "Huawei WMI hotkeys driver" > + depends on ACPI_WMI > + depends on INPUT > + select INPUT_SPARSEKMAP > + select LEDS_TRIGGERS > + select LEDS_TRIGGER_AUDIO I guess "select LEDS_CLASS" is needed as well. Other drivers had already it. > --- /dev/null > +++ b/drivers/platform/x86/huawei-wmi.c .... > +static int huawei_wmi_micmute_led_set(bool on) > +{ > + acpi_handle handle; > + char *method; > + union acpi_object args[3]; > + struct acpi_object_list arg_list = { > + .pointer = args, > + .count = ARRAY_SIZE(args), > + }; > + > + handle = ACPI_HANDLE(&inputdev->dev); > + args[0].type = args[1].type = args[2].type = ACPI_TYPE_INTEGER; > + args[1].integer.value = 0x04; > + > + if (acpi_has_method(handle, method = "\\_SB.PCI0.LPCB.EC0.SPIN")) { This looks ugly... And checkpatch also complains. > + args[0].integer.value = 0; > + args[2].integer.value = on ? 1 : 0; > + } else if (acpi_has_method(handle, method = "\\_SB.PCI0.LPCB.EC0.WPIN")) { > + args[0].integer.value = 1; > + args[2].integer.value = on ? 0 : 1; > + } else { > + dev_err(&inputdev->dev, "Unable to find ACPI method\n"); > + return -ENOSYS; > + } Can these checks be done at initialization phase? It doesn't seem needed to be executed at each call. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys. Date: Tue, 27 Nov 2018 12:02:39 +0100 Message-ID: References: <20181127025752.6459-1-ayman.bagabas@gmail.com> <20181127025752.6459-3-ayman.bagabas@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20181127025752.6459-3-ayman.bagabas@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Ayman Bagabas Cc: alsa-devel@alsa-project.org, Hui Wang , Andy Shevchenko , Darren Hart , Jaroslav Kysela , Kailang Yang , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org Some more forgotten bits... On Tue, 27 Nov 2018 03:57:48 +0100, Ayman Bagabas wrote: > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig .... > +config HUAWEI_WMI > + tristate "Huawei WMI hotkeys driver" > + depends on ACPI_WMI > + depends on INPUT > + select INPUT_SPARSEKMAP > + select LEDS_TRIGGERS > + select LEDS_TRIGGER_AUDIO I guess "select LEDS_CLASS" is needed as well. Other drivers had already it. > --- /dev/null > +++ b/drivers/platform/x86/huawei-wmi.c .... > +static int huawei_wmi_micmute_led_set(bool on) > +{ > + acpi_handle handle; > + char *method; > + union acpi_object args[3]; > + struct acpi_object_list arg_list = { > + .pointer = args, > + .count = ARRAY_SIZE(args), > + }; > + > + handle = ACPI_HANDLE(&inputdev->dev); > + args[0].type = args[1].type = args[2].type = ACPI_TYPE_INTEGER; > + args[1].integer.value = 0x04; > + > + if (acpi_has_method(handle, method = "\\_SB.PCI0.LPCB.EC0.SPIN")) { This looks ugly... And checkpatch also complains. > + args[0].integer.value = 0; > + args[2].integer.value = on ? 1 : 0; > + } else if (acpi_has_method(handle, method = "\\_SB.PCI0.LPCB.EC0.WPIN")) { > + args[0].integer.value = 1; > + args[2].integer.value = on ? 0 : 1; > + } else { > + dev_err(&inputdev->dev, "Unable to find ACPI method\n"); > + return -ENOSYS; > + } Can these checks be done at initialization phase? It doesn't seem needed to be executed at each call. thanks, Takashi