All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	alsa-devel@alsa-project.org,
	Rakesh Ughreja <rakesh.a.ughreja@intel.com>,
	kbuild test robot <lkp@intel.com>,
	kbuild-all@01.org
Subject: Re: [asoc:for-4.20 333/424] sound/pci/hda/patch_ca0132.c:7650:20: error: implicit declaration of function 'pci_iomap'; did you mean 'pcim_iomap'?
Date: Wed, 12 Sep 2018 14:01:05 +0200	[thread overview]
Message-ID: <s5hworq6i2m.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180912113128.GF6062@sirena.org.uk>

On Wed, 12 Sep 2018 13:31:28 +0200,
Mark Brown wrote:
> 
> On Tue, Sep 11, 2018 at 08:59:16AM +0200, Takashi Iwai wrote:
> 
> > Hrm, the header file inclusion of pci_iomap() looks fairly
> > inconsistent over architectures.  SH doesn't include asm/pci_iomap.h
> > from asm/io.h.  And x86 includes it from linux/io-mapping.h.
> 
> > As a quick fix, we can just include <asm/pci_iomap.h> from
> > patch_ca0132.c, I suppose.
> 
> Not on x86 we can't, it's not there - asm/io.h seems safest AFAICT,
> everyone has it and both SH and x86 include the pci_iomap.h.

Hmm, the code does include <linux/io.h>, and it includes <asm/io.h>

I don't think arch/sh/include/asm/io.h includes the necessary thing.


Takashi

  reply	other threads:[~2018-09-12 12:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11  5:29 [asoc:for-4.20 333/424] sound/pci/hda/patch_ca0132.c:7650:20: error: implicit declaration of function 'pci_iomap'; did you mean 'pcim_iomap'? kbuild test robot
2018-09-11  6:59 ` Takashi Iwai
2018-09-12 10:41   ` Mark Brown
2018-09-12 11:31   ` Mark Brown
2018-09-12 12:01     ` Takashi Iwai [this message]
2018-09-12 12:04       ` Mark Brown
2018-10-22 17:44         ` Pierre-Louis Bossart
2018-10-23 10:00           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hworq6i2m.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kbuild-all@01.org \
    --cc=lkp@intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rakesh.a.ughreja@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.