From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753931AbbE1Nw7 (ORCPT ); Thu, 28 May 2015 09:52:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51092 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207AbbE1Nwu (ORCPT ); Thu, 28 May 2015 09:52:50 -0400 Date: Thu, 28 May 2015 15:52:48 +0200 Message-ID: From: Takashi Iwai To: Quentin Lambert Cc: Johannes Berg , Jaroslav Kysela , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups In-Reply-To: <1432817307-28380-1-git-send-email-lambert.quentin@gmail.com> References: <1432817307-28380-1-git-send-email-lambert.quentin@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: > > You should use dev_groups instead of the dev_attrs field of struct > bus_type. This converts the MDIO bus code to use the correct field. > > These modifications were made using Coccinelle. > > Signed-off-by: Quentin Lambert What's wrong with dev_attrs? (Not offending, I'm just curious where the preference for dev_groups is referred...) thanks, Takashi > --- > sound/aoa/soundbus/core.c | 3 ++- > sound/aoa/soundbus/soundbus.h | 2 +- > sound/aoa/soundbus/sysfs.c | 13 ++++++++----- > 3 files changed, 11 insertions(+), 7 deletions(-) > > --- a/sound/aoa/soundbus/core.c > +++ b/sound/aoa/soundbus/core.c > @@ -150,6 +150,7 @@ static int soundbus_device_resume(struct > > #endif /* CONFIG_PM */ > > +ATTRIBUTE_GROUPS(soundbus_dev); > static struct bus_type soundbus_bus_type = { > .name = "aoa-soundbus", > .probe = soundbus_probe, > @@ -160,7 +161,7 @@ static struct bus_type soundbus_bus_type > .suspend = soundbus_device_suspend, > .resume = soundbus_device_resume, > #endif > - .dev_attrs = soundbus_dev_attrs, > + .dev_groups = soundbus_dev_groups, > }; > > int soundbus_add_one(struct soundbus_dev *dev) > --- a/sound/aoa/soundbus/soundbus.h > +++ b/sound/aoa/soundbus/soundbus.h > @@ -199,6 +199,6 @@ struct soundbus_driver { > extern int soundbus_register_driver(struct soundbus_driver *drv); > extern void soundbus_unregister_driver(struct soundbus_driver *drv); > > -extern struct device_attribute soundbus_dev_attrs[]; > +extern struct attribute *soundbus_dev_attrs[]; > > #endif /* __SOUNDBUS_H */ > --- a/sound/aoa/soundbus/sysfs.c > +++ b/sound/aoa/soundbus/sysfs.c > @@ -30,13 +30,16 @@ static ssize_t modalias_show(struct devi > > return length; > } > +static DEVICE_ATTR_RO(modalias); > > soundbus_config_of_attr (name, "%s\n"); > +static DEVICE_ATTR_RO(name); > soundbus_config_of_attr (type, "%s\n"); > +static DEVICE_ATTR_RO(type); > > -struct device_attribute soundbus_dev_attrs[] = { > - __ATTR_RO(name), > - __ATTR_RO(type), > - __ATTR_RO(modalias), > - __ATTR_NULL > +struct attribute *soundbus_dev_attrs[] = { > + &dev_attr_name.attr, > + &dev_attr_type.attr, > + &dev_attr_modalias.attr, > + NULL, > }; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Date: Thu, 28 May 2015 13:52:48 +0000 Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups Message-Id: List-Id: References: <1432817307-28380-1-git-send-email-lambert.quentin@gmail.com> In-Reply-To: <1432817307-28380-1-git-send-email-lambert.quentin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Quentin Lambert Cc: Johannes Berg , Jaroslav Kysela , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: > > You should use dev_groups instead of the dev_attrs field of struct > bus_type. This converts the MDIO bus code to use the correct field. > > These modifications were made using Coccinelle. > > Signed-off-by: Quentin Lambert What's wrong with dev_attrs? (Not offending, I'm just curious where the preference for dev_groups is referred...) thanks, Takashi > --- > sound/aoa/soundbus/core.c | 3 ++- > sound/aoa/soundbus/soundbus.h | 2 +- > sound/aoa/soundbus/sysfs.c | 13 ++++++++----- > 3 files changed, 11 insertions(+), 7 deletions(-) > > --- a/sound/aoa/soundbus/core.c > +++ b/sound/aoa/soundbus/core.c > @@ -150,6 +150,7 @@ static int soundbus_device_resume(struct > > #endif /* CONFIG_PM */ > > +ATTRIBUTE_GROUPS(soundbus_dev); > static struct bus_type soundbus_bus_type = { > .name = "aoa-soundbus", > .probe = soundbus_probe, > @@ -160,7 +161,7 @@ static struct bus_type soundbus_bus_type > .suspend = soundbus_device_suspend, > .resume = soundbus_device_resume, > #endif > - .dev_attrs = soundbus_dev_attrs, > + .dev_groups = soundbus_dev_groups, > }; > > int soundbus_add_one(struct soundbus_dev *dev) > --- a/sound/aoa/soundbus/soundbus.h > +++ b/sound/aoa/soundbus/soundbus.h > @@ -199,6 +199,6 @@ struct soundbus_driver { > extern int soundbus_register_driver(struct soundbus_driver *drv); > extern void soundbus_unregister_driver(struct soundbus_driver *drv); > > -extern struct device_attribute soundbus_dev_attrs[]; > +extern struct attribute *soundbus_dev_attrs[]; > > #endif /* __SOUNDBUS_H */ > --- a/sound/aoa/soundbus/sysfs.c > +++ b/sound/aoa/soundbus/sysfs.c > @@ -30,13 +30,16 @@ static ssize_t modalias_show(struct devi > > return length; > } > +static DEVICE_ATTR_RO(modalias); > > soundbus_config_of_attr (name, "%s\n"); > +static DEVICE_ATTR_RO(name); > soundbus_config_of_attr (type, "%s\n"); > +static DEVICE_ATTR_RO(type); > > -struct device_attribute soundbus_dev_attrs[] = { > - __ATTR_RO(name), > - __ATTR_RO(type), > - __ATTR_RO(modalias), > - __ATTR_NULL > +struct attribute *soundbus_dev_attrs[] = { > + &dev_attr_name.attr, > + &dev_attr_type.attr, > + &dev_attr_modalias.attr, > + NULL, > }; >