From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758901Ab2HHQnk (ORCPT ); Wed, 8 Aug 2012 12:43:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40482 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753274Ab2HHQnj (ORCPT ); Wed, 8 Aug 2012 12:43:39 -0400 Date: Wed, 08 Aug 2012 18:43:34 +0200 Message-ID: From: Takashi Iwai To: Arnd Bergmann Cc: Stephen Warren , linux-arm-kernel@lists.infradead.org, arm@kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Laxman Dewangan Subject: Re: [PATCH 11/11] pm/drivers: fix use of SIMPLE_DEV_PM_OPS In-Reply-To: <201208081622.29777.arnd@arndb.de> References: <1344437248-20560-1-git-send-email-arnd@arndb.de> <1344437248-20560-12-git-send-email-arnd@arndb.de> <50228889.5060709@wwwdotorg.org> <201208081622.29777.arnd@arndb.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 8 Aug 2012 16:22:29 +0000, Arnd Bergmann wrote: > > On Wednesday 08 August 2012, Stephen Warren wrote: > > On 08/08/2012 08:47 AM, Arnd Bergmann wrote: > > > A few drivers use a construct like > > > > > > #ifdef CONFIG_PM > > > static int foo_suspend(struct device *pdev) > > > { > > > ... > > > } > > > static int foo_resume struct device *pdev) > > > { > > > ... > > > } > > > #endif > > > static SIMPLE_DEV_PM_OPS(foo_pm, foo_suspend, foo_resume); > > ... > > > drivers/i2c/busses/i2c-tegra.c:716:12: warning: 'tegra_i2c_suspend' defined but not used [-Wunused-function] > > > drivers/i2c/busses/i2c-tegra.c:727:12: warning: 'tegra_i2c_resume' defined but not used [-Wunused-function] > > > > Laxman already posted a patch for this, which I'm hoping will make it > > into 3.6, through the I2C tree. > > > > http://www.spinics.net/lists/linux-i2c/msg09359.html > > Ok, dropping this one then. I'm going to fix the similar errors in sound tree tomorrow, too. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: tiwai@suse.de (Takashi Iwai) Date: Wed, 08 Aug 2012 18:43:34 +0200 Subject: [PATCH 11/11] pm/drivers: fix use of SIMPLE_DEV_PM_OPS In-Reply-To: <201208081622.29777.arnd@arndb.de> References: <1344437248-20560-1-git-send-email-arnd@arndb.de> <1344437248-20560-12-git-send-email-arnd@arndb.de> <50228889.5060709@wwwdotorg.org> <201208081622.29777.arnd@arndb.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org At Wed, 8 Aug 2012 16:22:29 +0000, Arnd Bergmann wrote: > > On Wednesday 08 August 2012, Stephen Warren wrote: > > On 08/08/2012 08:47 AM, Arnd Bergmann wrote: > > > A few drivers use a construct like > > > > > > #ifdef CONFIG_PM > > > static int foo_suspend(struct device *pdev) > > > { > > > ... > > > } > > > static int foo_resume struct device *pdev) > > > { > > > ... > > > } > > > #endif > > > static SIMPLE_DEV_PM_OPS(foo_pm, foo_suspend, foo_resume); > > ... > > > drivers/i2c/busses/i2c-tegra.c:716:12: warning: 'tegra_i2c_suspend' defined but not used [-Wunused-function] > > > drivers/i2c/busses/i2c-tegra.c:727:12: warning: 'tegra_i2c_resume' defined but not used [-Wunused-function] > > > > Laxman already posted a patch for this, which I'm hoping will make it > > into 3.6, through the I2C tree. > > > > http://www.spinics.net/lists/linux-i2c/msg09359.html > > Ok, dropping this one then. I'm going to fix the similar errors in sound tree tomorrow, too. thanks, Takashi