From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Fwd: [PATCH] sound working on the macbook pro Date: Mon, 12 Mar 2007 16:00:38 +0100 Message-ID: References: <564d96fb0702180906u6dc0f0d9k2cd1d5e1409f1911@mail.gmail.com> <564d96fb0702200140u7aee7dfbt271ed3818ed92366@mail.gmail.com> <564d96fb0702201205i11beca64g11ca9602a53ad433@mail.gmail.com> <564d96fb0702221201o54468523k20976544157c99c8@mail.gmail.com> <564d96fb0702262134t438dd480t45c83e556f315e2e@mail.gmail.com> <564d96fb0703092157t5b7f171cr1f94125cac32b782@mail.gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <564d96fb0703092157t5b7f171cr1f94125cac32b782@mail.gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: =?UTF-8?Q?Rafael_Esp=C3=ADndola?= Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Fri, 9 Mar 2007 21:57:45 -0800, =?UTF-8?Q?Rafael_Esp=C3=ADndola?= wrote: > > > Then it means that stac92xx_hp_detect() isn't called properly, or the > > pin-detection doesn't work with your hardware. Otherwise > > stac92xx_auto_init_multiout() should enable this pin. Could you check > > whether stac92xx_hp_detect() is called and how is it processed > > (e.g. by adding printk's)? Also, add a printk in > > stac92xx_auto_init_multiout() to make sure that this isn't called. > > all tests performed with the new pin config. > with the fix-up enabled: > *) stac92xx_auto_init_multi_out is not called > *) stac92xx_hp_detect is called: > cfg->hp_outs = 1 > presence = 0 after the first loop > cfg->line_outs = 3 > cfg->speaker_outs = 0 > *) speakers don't work > > with the fix-up disabled: > *) stac92xx_auto_init_multi_out in not called > *) stac92xx_hp_detect is called: > cfg->hp_outs = 1 > presense = 0 after the first loop > cfg->line_outs = 0 > cfg->speaker_outs = 1 > *) speakers work I guess it's a missing initialization for the first line-out jack. It works on ohter devices because the default PIN setup has AC_PIN_OUT_EN. But, on Mac, it has AC_PIN_IN_EN by some reason. The patch below should fix the problm. Give it a try. Takashi diff -r e87b2114ceae pci/hda/patch_sigmatel.c --- a/pci/hda/patch_sigmatel.c Mon Mar 12 12:54:23 2007 +0100 +++ b/pci/hda/patch_sigmatel.c Mon Mar 12 15:56:58 2007 +0100 @@ -1600,6 +1600,11 @@ static int stac92xx_init(struct hda_code for (i = 0; i < cfg->hp_outs; i++) enable_pin_detect(codec, cfg->hp_pins[i], STAC_HP_EVENT); + /* force to enable the first line-out; the others are set up + * in unsol_event + */ + stac92xx_auto_set_pinctl(codec, spec->autocfg.line_out_pins[0], + AC_PINCTL_OUT_EN); stac92xx_auto_init_hp_out(codec); /* fake event to set up pins */ codec->patch_ops.unsol_event(codec, STAC_HP_EVENT << 26); ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV