From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F89C433F5 for ; Wed, 23 Feb 2022 14:55:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241774AbiBWO4X (ORCPT ); Wed, 23 Feb 2022 09:56:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231152AbiBWO4W (ORCPT ); Wed, 23 Feb 2022 09:56:22 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F9B2B65E9 for ; Wed, 23 Feb 2022 06:55:55 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 1BF251F43D; Wed, 23 Feb 2022 14:55:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1645628154; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8p03YFSiQNYbmpdsHRPWLLm9yRxaqTmYDt6YPNvOYuc=; b=dCoFYXHJqJOuPfQ10Gjy0smCHzI5UqlCM5C26sm1cHxRdor+0qIaKalp9r9hiL8fff2w84 9iFxafCtJxJYjmEamz3qRAevdF+HLXPWu5MDsyj7cMP+DBgk+ILXMpCrZ6bQRIQdi4fRAo UtbldQu+8dx7TgMm1AbpPymJ6rvxzts= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1645628154; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8p03YFSiQNYbmpdsHRPWLLm9yRxaqTmYDt6YPNvOYuc=; b=ChEjBgXjp3n30A1chu0JGP69O7X2htRlokSQAwrc2pl01FTpCf6K81aINMpacoD2cDqp9W 1dOvXuaN/rt90BDA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 115FFA3B81; Wed, 23 Feb 2022 14:55:54 +0000 (UTC) Date: Wed, 23 Feb 2022 15:55:54 +0100 Message-ID: From: Takashi Iwai To: Marek Vasut Cc: alsa-devel@alsa-project.org, Mark Brown , stable@vger.kernel.org Subject: Re: [PATCH] ASoC: ops: Shift tested values in snd_soc_put_volsw() by +min In-Reply-To: <20220215130645.164025-1-marex@denx.de> References: <20220215130645.164025-1-marex@denx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, 15 Feb 2022 14:06:45 +0100, Marek Vasut wrote: > > While the $val/$val2 values passed in from userspace are always >= 0 > integers, the limits of the control can be signed integers and the $min > can be non-zero and less than zero. To correctly validate $val/$val2 > against platform_max, add the $min offset to val first. > > Fixes: 817f7c9335ec0 ("ASoC: ops: Reject out of bounds values in snd_soc_put_volsw()") > Signed-off-by: Marek Vasut > Cc: Mark Brown > Cc: stable@vger.kernel.org Now I'm looking at this since I pulled Mark's PR, and noticed that snd_soc_put_volsw_sx() may have a similar problem. Care to cover that, too? But, more reading the code, I suspect whether the function does work correctly at all... How is the mask calculation done in that way? unsigned int mask = (1U << (fls(min + max) - 1)) - 1; What's the difference of this function with snd_soc_put_volsw()? Furthermore, the mask calculation and usage in snd_soc_put_volsw() isn't right, either, I'm afraid; if the range is [-10, 0], max=0, then mask will 0, which will omit all values... I guess we need to revisit those functions (or I need more coffee). thanks, Takashi