From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B612C6778F for ; Fri, 27 Jul 2018 09:49:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E98A920895 for ; Fri, 27 Jul 2018 09:49:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E98A920895 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389010AbeG0LK4 (ORCPT ); Fri, 27 Jul 2018 07:10:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:56298 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729431AbeG0LKz (ORCPT ); Fri, 27 Jul 2018 07:10:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9E526B059; Fri, 27 Jul 2018 09:49:48 +0000 (UTC) Date: Fri, 27 Jul 2018 11:49:48 +0200 Message-ID: From: Takashi Iwai To: "Jia-Ju Bai" Cc: , , , Subject: Re: [PATCH] sound: pci: cthw20k1: Replace mdelay() with msleep() In-Reply-To: <20180727085756.12440-1-baijiaju1990@gmail.com> References: <20180727085756.12440-1-baijiaju1990@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Jul 2018 10:57:56 +0200, Jia-Ju Bai wrote: > > hw_pll_init(), hw_reset_dac() and hw_card_init() are never > called in atomic context. > They calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied, thanks. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] sound: pci: cthw20k1: Replace mdelay() with msleep() Date: Fri, 27 Jul 2018 11:49:48 +0200 Message-ID: References: <20180727085756.12440-1-baijiaju1990@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20180727085756.12440-1-baijiaju1990@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Jia-Ju Bai Cc: bhumirks@gmail.com, perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Fri, 27 Jul 2018 10:57:56 +0200, Jia-Ju Bai wrote: > > hw_pll_init(), hw_reset_dac() and hw_card_init() are never > called in atomic context. > They calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied, thanks. Takashi