From: Takashi Iwai <tiwai@suse.de>
To: Raymond Yau <superquad.vortex2@gmail.com>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: snd_array_free - snd: bad kfree when HDA reconfig
Date: Wed, 14 Sep 2011 08:02:37 +0200 [thread overview]
Message-ID: <s5hy5xrek5e.wl%tiwai@suse.de> (raw)
In-Reply-To: <CAN8cciaVf7eoenrPmR2d4gxqyqs4TAk1OVt3wgzLi_qo09hQuw@mail.gmail.com>
At Wed, 14 Sep 2011 08:04:46 +0800,
Raymond Yau wrote:
>
> 2011/9/12 Takashi Iwai <tiwai@suse.de>:
> > At Fri, 2 Sep 2011 15:16:28 +0800,
> > Raymond Yau wrote:
> >>
> >> These errors "snd: bad kfree" occur when reconfig HDA from model
> >> "6stack-dig-fp" to "auto" and vice versa
> >
> > Doesn't this happen when you unload the device, right?
>
> These errors "snd: bad kfree" also happen when unload and reload the driver
>
> rmmod snd-hda-intel
> insmod snd-hda-inteel
OK, then it's just alsa-driver's debug stuff, no problem in the kernel
tree itself.
> > And, it happens when writing to /sys/class/sound/hwC0D0/clear?
> >
> >> Is "HD-Audio reconfiguration" still experimental ?
> >
> > Somehow yet, but mostly it worked for me :)
> >
>
> I just use hda reconfig to change the model="auto" to "6stack-dig-fp"
> and vice versa
>
> This mean that I need to implement "Independent HP" switch which allow
> user to change the topology if this feature is still experimental
The feature is anyway optional (i.e. not all users enable it).
> >> ALSA hda_hwdep.c:220: hda-codec: reconfiguring
> >> snd: bad kfree (called from f8be4636)
> >
> > Hmm, this is a magic check in external alsa-driver builds.
> > I guess it's just a bug there -- the override of krealloc() is
> > missing.
> >
> > Does the patch below (to alsa-driver tree) fix the problem?
> >
>
> Do I need to specify any option and run configure script again ?
No.
> alsa-driver compiled without error but fail to loaded and complain
> ksize undefined symbol
Try the patch below in addition to the previous one.
thanks,
Takashi
---
From: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] Add missing export of snd_hidden_ksize()
Also fix the ifdef of krealloc() wrapper for some corner cases.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
acore/sound.inc | 1 +
include/adriver.h | 3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/acore/sound.inc b/acore/sound.inc
index a79755e..2e63c98 100644
--- a/acore/sound.inc
+++ b/acore/sound.inc
@@ -3,6 +3,7 @@
EXPORT_SYMBOL(snd_hidden_kmalloc);
EXPORT_SYMBOL(snd_hidden_kzalloc);
EXPORT_SYMBOL(snd_hidden_kcalloc);
+EXPORT_SYMBOL(snd_hidden_ksize);
EXPORT_SYMBOL(snd_hidden_kfree);
EXPORT_SYMBOL(snd_hidden_kstrdup);
EXPORT_SYMBOL(snd_hidden_kstrndup);
diff --git a/include/adriver.h b/include/adriver.h
index fe70442..848bc17 100644
--- a/include/adriver.h
+++ b/include/adriver.h
@@ -2002,7 +2002,8 @@ static inline bool flush_delayed_work_sync(struct delayed_work *dwork)
#endif
/* krealloc() wrapper */
-#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 0) && LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 22)) || defined(CONFIG_SND_DEBUG_MEMORY)
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 0) && LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 22)) || \
+ (defined(CONFIG_SND_DEBUG_MEMORY) && !defined(SKIP_HIDDEN_MALLOCS))
#include <linux/slab.h>
static inline void *snd_compat_krealloc(const void *p, size_t new_size, gfp_t flags)
{
--
1.7.6.1
next prev parent reply other threads:[~2011-09-14 6:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 7:16 snd_array_free - snd: bad kfree when HDA reconfig Raymond Yau
2011-09-12 7:46 ` Takashi Iwai
2011-09-14 0:04 ` Raymond Yau
2011-09-14 6:02 ` Takashi Iwai [this message]
2011-09-15 14:23 ` Raymond Yau
2011-09-15 14:30 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy5xrek5e.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=superquad.vortex2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.