All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Emu10k1 - STAC9758 (fixes #2308)
@ 2007-02-05 18:16 Rolf Stefan Wilke
  2007-02-06 11:26 ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Rolf Stefan Wilke @ 2007-02-05 18:16 UTC (permalink / raw)
  To: alsa-devel; +Cc: James

The following patch fixes bug #2308 [no sound on front channel for 
emu10k1 - sigmatel STAC9758]; at least for me. Thanks to Raymond at bugtrack!

	Stefan

--- alsa-driver-1.0.14rc2.orig/alsa-kernel/pci/emu10k1/emumixer.c       
2007-01-15 14:25:27.000000000 +0100
+++ alsa-driver-1.0.14rc2/alsa-kernel/pci/emu10k1/emumixer.c    2007-02-05 
19:10:48.000000000 +0100
@@ -1582,6 +1582,7 @@
                        if (emu->ac97->id == AC97_ID_STAC9758) {
                                emu->rear_ac97 = 1;
                                snd_emu10k1_ptr_write(emu, AC97SLOT, 0, 
AC97SLOT_CNTR|AC97SLOT_LFE|AC97SLOT_REAR_LEFT|AC97SLOT_REAR_RIGHT);
+                               snd_ac97_write_cache(emu->ac97, 0x04, 0x0202);
                        }
                        /* remove unused AC97 controls */
                        snd_ac97_write_cache(emu->ac97, AC97_SURROUND_MASTER, 
0x0202);

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Emu10k1 - STAC9758 (fixes #2308)
  2007-02-05 18:16 [PATCH] Emu10k1 - STAC9758 (fixes #2308) Rolf Stefan Wilke
@ 2007-02-06 11:26 ` Takashi Iwai
  2007-02-06 18:10   ` Rolf Stefan Wilke
  0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2007-02-06 11:26 UTC (permalink / raw)
  To: stefan.wilke; +Cc: alsa-devel

At Mon, 5 Feb 2007 19:16:35 +0100,
Rolf Stefan Wilke wrote:
> 
> The following patch fixes bug #2308 [no sound on front channel for 
> emu10k1 - sigmatel STAC9758]; at least for me. Thanks to Raymond at bugtrack!
> 
> 	Stefan
> 
> --- alsa-driver-1.0.14rc2.orig/alsa-kernel/pci/emu10k1/emumixer.c       
> 2007-01-15 14:25:27.000000000 +0100
> +++ alsa-driver-1.0.14rc2/alsa-kernel/pci/emu10k1/emumixer.c    2007-02-05 
> 19:10:48.000000000 +0100
> @@ -1582,6 +1582,7 @@
>                         if (emu->ac97->id == AC97_ID_STAC9758) {
>                                 emu->rear_ac97 = 1;
>                                 snd_emu10k1_ptr_write(emu, AC97SLOT, 0, 
> AC97SLOT_CNTR|AC97SLOT_LFE|AC97SLOT_REAR_LEFT|AC97SLOT_REAR_RIGHT);
> +                               snd_ac97_write_cache(emu->ac97, 0x04, 0x0202);

Replace 0x04 with AC97_HEADPHONE, which explains better.
Also, your MUA doesn't work with the embedded patch, and it cannot be
applied cleanly.  Use attachments in such a case.

Otherwise the patch looks good to me.  Could you provide a proper
changelog (the subject and the description of the patch) and a
sign-off (Signed-off-by: XXX <xxx@xxx>) for merging to the upstream,
too?


Thanks,

Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Emu10k1 - STAC9758 (fixes #2308)
  2007-02-06 11:26 ` Takashi Iwai
@ 2007-02-06 18:10   ` Rolf Stefan Wilke
  2007-02-06 18:21     ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Rolf Stefan Wilke @ 2007-02-06 18:10 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

Thanks for your answer. I hope this is a more appropriate description; if not, 
let me know. I'm unexperienced, yet eager to learn ;-)

Summary: The following patch (hopefully) fixes bug #2308 for users of STAC9758

For some time now, some users of STAC9758 (emu10k1) would have no sound on 
their front channels. This can be fixed (at least for me) by unmuting  head 
phone volume and setting it to 0dB before removing the "Front Playback" 
control. For details, cf.
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2308
Find the appropriate patch attached.

Credits to: Raymond

Signed-off-by: Rolf Stefan Wilke <stefan.wilke@uni-ulm.de>

 


[-- Attachment #2: emumixer.patch --]
[-- Type: text/x-diff, Size: 577 bytes --]

--- alsa-driver-1.0.14rc2.orig/alsa-kernel/pci/emu10k1/emumixer.c	2007-01-15 14:25:27.000000000 +0100
+++ alsa-driver-1.0.14rc2/alsa-kernel/pci/emu10k1/emumixer.c	2007-02-06 18:34:51.000000000 +0100
@@ -1582,6 +1582,7 @@
 			if (emu->ac97->id == AC97_ID_STAC9758) {
 				emu->rear_ac97 = 1;
 				snd_emu10k1_ptr_write(emu, AC97SLOT, 0, AC97SLOT_CNTR|AC97SLOT_LFE|AC97SLOT_REAR_LEFT|AC97SLOT_REAR_RIGHT);
+				snd_ac97_write_cache(emu->ac97, AC97_HEADPHONE, 0x0202);
 			}
 			/* remove unused AC97 controls */
 			snd_ac97_write_cache(emu->ac97, AC97_SURROUND_MASTER, 0x0202);

[-- Attachment #3: Type: text/plain, Size: 374 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Emu10k1 - STAC9758 (fixes #2308)
  2007-02-06 18:10   ` Rolf Stefan Wilke
@ 2007-02-06 18:21     ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2007-02-06 18:21 UTC (permalink / raw)
  To: stefan.wilke; +Cc: alsa-devel

At Tue, 6 Feb 2007 19:10:03 +0100,
Rolf Stefan Wilke wrote:
> 
> Thanks for your answer. I hope this is a more appropriate description; if not, 
> let me know. I'm unexperienced, yet eager to learn ;-)

Pretty well, although the summary line could be more concise (so I
changed it a bit).

> Summary: The following patch (hopefully) fixes bug #2308 for users of STAC9758
> 
> For some time now, some users of STAC9758 (emu10k1) would have no sound on 
> their front channels. This can be fixed (at least for me) by unmuting  head 
> phone volume and setting it to 0dB before removing the "Front Playback" 
> control. For details, cf.
> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2308
> Find the appropriate patch attached.
> 
> Credits to: Raymond
> 
> Signed-off-by: Rolf Stefan Wilke <stefan.wilke@uni-ulm.de>

I applied it now to ALSA HG tree.  Thanks!


Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-02-06 18:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-05 18:16 [PATCH] Emu10k1 - STAC9758 (fixes #2308) Rolf Stefan Wilke
2007-02-06 11:26 ` Takashi Iwai
2007-02-06 18:10   ` Rolf Stefan Wilke
2007-02-06 18:21     ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.