From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D40C2B9F8 for ; Tue, 25 May 2021 08:36:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 403456141B for ; Tue, 25 May 2021 08:36:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231371AbhEYIhi (ORCPT ); Tue, 25 May 2021 04:37:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:49506 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232477AbhEYIhT (ORCPT ); Tue, 25 May 2021 04:37:19 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621931714; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/8Tj70cnh3z488JIeA9Dqfr+VizsEJXzWnqypGpv3Kg=; b=rIxtavIsMX8VaZtrpgtmz+W9NJE1HyUiTsp/kfxLCuVznHH8PYBZ/32Ecm2zT4W7cJP2Vh 9Yqgii8ks9JIuVX6klmZgAc2VGPN6UvNRpekNmIlkpDi6l/qT623ZiwkIC0SUTZ0jpd28j hsmm05h/Yuv9e79CH7icWt8v3dtSuhI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621931714; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/8Tj70cnh3z488JIeA9Dqfr+VizsEJXzWnqypGpv3Kg=; b=1TEssWfK11ZnzAISIyhB1tJfLxPJ3IwYrn6gQsEq3aT+izjyOjVV2rDV7k4IxBbLkQdRXo w9ZOjPGvUBHLz1DQ== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 63C34AEA8; Tue, 25 May 2021 08:35:14 +0000 (UTC) Date: Tue, 25 May 2021 10:35:14 +0200 Message-ID: From: Takashi Iwai To: Maxime Ripard Cc: Mark Brown , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Dom Cobley , Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, Eric Anholt , Rob Herring , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Daniel Vetter , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec In-Reply-To: <20210524133904.kgkh6xd3m5c2j3xa@gilmour> References: <20210507140334.204865-1-maxime@cerno.tech> <20210524133904.kgkh6xd3m5c2j3xa@gilmour> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 May 2021 15:39:04 +0200, Maxime Ripard wrote: > > Hi, > > On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > > Hi, > > > > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place, > > it's missing a few controls to be able to provide HBR passthrough. This series > > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > > controller driver. > > > > One thing that felt a bit weird is that even though > > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-driver.html#iec958-s-pdif > > mentions that the iec958 mask control should be a mixer control and the > > default control should be a PCM one, it feels a bit weird to have two different > > control type for two controls so similar, and other drivers are pretty > > inconsistent with this. Should we update the documentation? > > Any comments on this series? A patch for updating the documentation is welcome. Currently, as de facto standard, we allow both MIXER and PCM ifaces for all IEC958-related controls, and it's unlikely that we would change that in future. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B49C4707F for ; Tue, 25 May 2021 08:36:11 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BD9C61400 for ; Tue, 25 May 2021 08:36:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BD9C61400 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 08CE01612; Tue, 25 May 2021 10:35:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 08CE01612 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621931769; bh=nmeatVCV6b4kFGUiccWwfPuUtRagbBSRaDx2LzsHouE=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BB9kvxVrrsT34WQ4X3BBqJIEs/OjNm804fzStWjrOryBeKYk3gIIo0I0Z/rdQGQcE MBadQKWvQlp752WaJi4RoMyym4mXtoZN1T41x/9Ee9BbqgYYkGGUDPZR1hkg4RP6h5 D7zarj/un150naWp5n8eves8f659cjRfPbSZUfL4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A40BFF8019D; Tue, 25 May 2021 10:35:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D3191F80137; Tue, 25 May 2021 10:35:17 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B2307F80137 for ; Tue, 25 May 2021 10:35:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B2307F80137 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rIxtavIs"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="1TEssWfK" X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621931714; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/8Tj70cnh3z488JIeA9Dqfr+VizsEJXzWnqypGpv3Kg=; b=rIxtavIsMX8VaZtrpgtmz+W9NJE1HyUiTsp/kfxLCuVznHH8PYBZ/32Ecm2zT4W7cJP2Vh 9Yqgii8ks9JIuVX6klmZgAc2VGPN6UvNRpekNmIlkpDi6l/qT623ZiwkIC0SUTZ0jpd28j hsmm05h/Yuv9e79CH7icWt8v3dtSuhI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621931714; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/8Tj70cnh3z488JIeA9Dqfr+VizsEJXzWnqypGpv3Kg=; b=1TEssWfK11ZnzAISIyhB1tJfLxPJ3IwYrn6gQsEq3aT+izjyOjVV2rDV7k4IxBbLkQdRXo w9ZOjPGvUBHLz1DQ== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 63C34AEA8; Tue, 25 May 2021 08:35:14 +0000 (UTC) Date: Tue, 25 May 2021 10:35:14 +0200 Message-ID: From: Takashi Iwai To: Maxime Ripard Subject: Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec In-Reply-To: <20210524133904.kgkh6xd3m5c2j3xa@gilmour> References: <20210507140334.204865-1-maxime@cerno.tech> <20210524133904.kgkh6xd3m5c2j3xa@gilmour> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Tim Gover , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Eric Anholt , Daniel Vetter , Phil Elwell , Dave Stevenson , Takashi Iwai , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, Nicolas Saenz Julienne , Daniel Vetter , Maarten Lankhorst , Mark Brown , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dom Cobley , Liam Girdwood , Rob Herring , Thomas Zimmermann X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 24 May 2021 15:39:04 +0200, Maxime Ripard wrote: > > Hi, > > On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > > Hi, > > > > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place, > > it's missing a few controls to be able to provide HBR passthrough. This series > > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > > controller driver. > > > > One thing that felt a bit weird is that even though > > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-driver.html#iec958-s-pdif > > mentions that the iec958 mask control should be a mixer control and the > > default control should be a PCM one, it feels a bit weird to have two different > > control type for two controls so similar, and other drivers are pretty > > inconsistent with this. Should we update the documentation? > > Any comments on this series? A patch for updating the documentation is welcome. Currently, as de facto standard, we allow both MIXER and PCM ifaces for all IEC958-related controls, and it's unlikely that we would change that in future. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE25FC2B9F8 for ; Tue, 25 May 2021 08:36:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB3C061284 for ; Tue, 25 May 2021 08:36:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB3C061284 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PPJoM93orKcILCicMcv65yEBUMKbMn3UGt13m1yLMZE=; b=32U7sGNV4dsbG5 FdlnYQjNhuhwKYatLM38oVTuj4qN6WKYkdgUrBMs5UsnpE3DNHePBCPMwKl99XipankegC7DsNzyX oevPMtk+Ntg1+I+aIcDPq4mFGCIYJG1ZwUrSaXQxzN5VX12troDFxxtEGgO3O2GLYPmmB1AJ/eTqv JshttVq541yr4JmttiY7gL6bCEQ2bUqFFoW1rImTkZ8iUgKNfqnhxFVUzKl0AtGQS/dT9tvaU8Wlf /vXejjh/tE4pPnXORFZqBAKtNDkFYoiScoq5JK6592kr8uBxJRx3fHeoNjavGmkPWjv0kFBLOW1X6 afw/rASLUCytC/Nf7I5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llSX2-0046bs-DO; Tue, 25 May 2021 08:35:20 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llSWx-0046aE-Qx; Tue, 25 May 2021 08:35:17 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621931714; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/8Tj70cnh3z488JIeA9Dqfr+VizsEJXzWnqypGpv3Kg=; b=rIxtavIsMX8VaZtrpgtmz+W9NJE1HyUiTsp/kfxLCuVznHH8PYBZ/32Ecm2zT4W7cJP2Vh 9Yqgii8ks9JIuVX6klmZgAc2VGPN6UvNRpekNmIlkpDi6l/qT623ZiwkIC0SUTZ0jpd28j hsmm05h/Yuv9e79CH7icWt8v3dtSuhI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621931714; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/8Tj70cnh3z488JIeA9Dqfr+VizsEJXzWnqypGpv3Kg=; b=1TEssWfK11ZnzAISIyhB1tJfLxPJ3IwYrn6gQsEq3aT+izjyOjVV2rDV7k4IxBbLkQdRXo w9ZOjPGvUBHLz1DQ== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 63C34AEA8; Tue, 25 May 2021 08:35:14 +0000 (UTC) Date: Tue, 25 May 2021 10:35:14 +0200 Message-ID: From: Takashi Iwai To: Maxime Ripard Cc: Mark Brown , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Dom Cobley , Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, Eric Anholt , Rob Herring , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Daniel Vetter , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec In-Reply-To: <20210524133904.kgkh6xd3m5c2j3xa@gilmour> References: <20210507140334.204865-1-maxime@cerno.tech> <20210524133904.kgkh6xd3m5c2j3xa@gilmour> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_013516_047574_CD300102 X-CRM114-Status: GOOD ( 21.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 24 May 2021 15:39:04 +0200, Maxime Ripard wrote: > > Hi, > > On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > > Hi, > > > > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place, > > it's missing a few controls to be able to provide HBR passthrough. This series > > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > > controller driver. > > > > One thing that felt a bit weird is that even though > > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-driver.html#iec958-s-pdif > > mentions that the iec958 mask control should be a mixer control and the > > default control should be a PCM one, it feels a bit weird to have two different > > control type for two controls so similar, and other drivers are pretty > > inconsistent with this. Should we update the documentation? > > Any comments on this series? A patch for updating the documentation is welcome. Currently, as de facto standard, we allow both MIXER and PCM ifaces for all IEC958-related controls, and it's unlikely that we would change that in future. thanks, Takashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A83C2B9F8 for ; Tue, 25 May 2021 08:35:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3556061400 for ; Tue, 25 May 2021 08:35:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3556061400 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9236E6E8C7; Tue, 25 May 2021 08:35:18 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5EBBE6E8C7 for ; Tue, 25 May 2021 08:35:15 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621931714; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/8Tj70cnh3z488JIeA9Dqfr+VizsEJXzWnqypGpv3Kg=; b=rIxtavIsMX8VaZtrpgtmz+W9NJE1HyUiTsp/kfxLCuVznHH8PYBZ/32Ecm2zT4W7cJP2Vh 9Yqgii8ks9JIuVX6klmZgAc2VGPN6UvNRpekNmIlkpDi6l/qT623ZiwkIC0SUTZ0jpd28j hsmm05h/Yuv9e79CH7icWt8v3dtSuhI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621931714; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/8Tj70cnh3z488JIeA9Dqfr+VizsEJXzWnqypGpv3Kg=; b=1TEssWfK11ZnzAISIyhB1tJfLxPJ3IwYrn6gQsEq3aT+izjyOjVV2rDV7k4IxBbLkQdRXo w9ZOjPGvUBHLz1DQ== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 63C34AEA8; Tue, 25 May 2021 08:35:14 +0000 (UTC) Date: Tue, 25 May 2021 10:35:14 +0200 Message-ID: From: Takashi Iwai To: Maxime Ripard Subject: Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec In-Reply-To: <20210524133904.kgkh6xd3m5c2j3xa@gilmour> References: <20210507140334.204865-1-maxime@cerno.tech> <20210524133904.kgkh6xd3m5c2j3xa@gilmour> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Tim Gover , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , Phil Elwell , Dave Stevenson , Takashi Iwai , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, Nicolas Saenz Julienne , Mark Brown , linux-rpi-kernel@lists.infradead.org, Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, Dom Cobley , Liam Girdwood , Rob Herring , Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 24 May 2021 15:39:04 +0200, Maxime Ripard wrote: > > Hi, > > On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > > Hi, > > > > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place, > > it's missing a few controls to be able to provide HBR passthrough. This series > > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > > controller driver. > > > > One thing that felt a bit weird is that even though > > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-driver.html#iec958-s-pdif > > mentions that the iec958 mask control should be a mixer control and the > > default control should be a PCM one, it feels a bit weird to have two different > > control type for two controls so similar, and other drivers are pretty > > inconsistent with this. Should we update the documentation? > > Any comments on this series? A patch for updating the documentation is welcome. Currently, as de facto standard, we allow both MIXER and PCM ifaces for all IEC958-related controls, and it's unlikely that we would change that in future. thanks, Takashi