* [PATCH] ALSA: fixing upper volume limit for RME Babyface Pro routing crosspoints.
@ 2020-05-15 11:46 Thomas Ebeling
2020-05-15 15:08 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Ebeling @ 2020-05-15 11:46 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai
In my initial patch, these were set too low.
Signed-off-by: Thomas Ebeling <penguins@bollie.de>
---
sound/usb/mixer_quirks.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
index bdff8674942e..aad2683ff793 100644
--- a/sound/usb/mixer_quirks.c
+++ b/sound/usb/mixer_quirks.c
@@ -2191,7 +2191,7 @@ static int snd_rme_controls_create(struct usb_mixer_interface *mixer)
* These devices exposes a couple of DSP functions via request to EP0.
* Switches are available via control registers, while routing is controlled
* by controlling the volume on each possible crossing point.
- * Volume control is linear, from -inf (dec. 0) to +6dB (dec. 46341) with
+ * Volume control is linear, from -inf (dec. 0) to +6dB (dec. 65536) with
* 0dB being at dec. 32768.
*/
enum {
@@ -2220,7 +2220,7 @@ enum {
#define SND_BBFPRO_MIXER_VAL_MASK 0x3ffff
#define SND_BBFPRO_MIXER_VAL_SHIFT 9
#define SND_BBFPRO_MIXER_VAL_MIN 0 // -inf
-#define SND_BBFPRO_MIXER_VAL_MAX 46341 // +6dB
+#define SND_BBFPRO_MIXER_VAL_MAX 65536 // +6dB
#define SND_BBFPRO_USBREQ_CTL_REG1 0x10
#define SND_BBFPRO_USBREQ_CTL_REG2 0x17
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: fixing upper volume limit for RME Babyface Pro routing crosspoints.
2020-05-15 11:46 [PATCH] ALSA: fixing upper volume limit for RME Babyface Pro routing crosspoints Thomas Ebeling
@ 2020-05-15 15:08 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2020-05-15 15:08 UTC (permalink / raw)
To: Thomas Ebeling; +Cc: alsa-devel, tiwai
On Fri, 15 May 2020 13:46:05 +0200,
Thomas Ebeling wrote:
>
> In my initial patch, these were set too low.
>
> Signed-off-by: Thomas Ebeling <penguins@bollie.de>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-15 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-15 11:46 [PATCH] ALSA: fixing upper volume limit for RME Babyface Pro routing crosspoints Thomas Ebeling
2020-05-15 15:08 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.