All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	akpm@linux-foundation.org, broonie@kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz,
	mm-commits@vger.kernel.org, sfr@canb.auug.org.au,
	moderated for non-subscribers <alsa-devel@alsa-project.org>
Subject: Re: [alsa-devel] mmotm 2019-08-27-20-39 uploaded       (sound/hda/intel-nhlt.c)
Date: Thu, 29 Aug 2019 17:08:21 +0200	[thread overview]
Message-ID: <s5hzhjs102i.wl-tiwai@suse.de> (raw)
In-Reply-To: <19edfb9a-f7b3-7a89-db5a-33289559aeef@linux.intel.com>

On Thu, 29 Aug 2019 00:45:05 +0200,
Pierre-Louis Bossart wrote:
> 
> 
> >>> I just checked with Mark Brown's for-next tree
> >>> 8aceffa09b4b9867153bfe0ff6f40517240cee12
> >>> and things are fine in i386 mode, see below.
> >>>
> >>> next-20190828 also works fine for me in i386 mode.
> >>>
> >>> if you can point me to a tree and configuration that don't work
> >>> I'll look into this, I'd need more info to progress.
> >>
> >> Please try the attached randconfig file.
> >>
> >> Thanks for looking.
> >
> > Ack, I see some errors as well with this config. Likely a missing
> > dependency somewhere, working on this now.
> 
> My bad, I added a fallback with static inline functions in the .h file
> when ACPI is not defined, but the .c file was still compiled.
> 
> The diff below makes next-20190828 compile with Randy's config.

IMO, we need to fix the site that enables this config.  i.e.
the "select SND_INTEL_NHLT" must be always conditional, e.g.
	select SND_INTEL_NHLT if ACPI

> It looks like the alsa-devel server is down btw?

Now it seems starting again.


thanks,

Takashi

> diff --git a/sound/hda/Makefile b/sound/hda/Makefile
> index 8560f6ef1b19..b3af071ce06b 100644
> --- a/sound/hda/Makefile
> +++ b/sound/hda/Makefile
> @@ -14,5 +14,7 @@ obj-$(CONFIG_SND_HDA_CORE) += snd-hda-core.o
>  #extended hda
>  obj-$(CONFIG_SND_HDA_EXT_CORE) += ext/
> 
> +ifdef CONFIG_ACPI
>  snd-intel-nhlt-objs := intel-nhlt.o
>  obj-$(CONFIG_SND_INTEL_NHLT) += snd-intel-nhlt.o
> +endif
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	akpm@linux-foundation.org, broonie@kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz,
	mm-commits@vger.kernel.org, sfr@canb.auug.org.au,
	moderated for non-subscribers <alsa-devel@alsa-project.org>
Subject: Re: [alsa-devel] mmotm 2019-08-27-20-39 uploaded	(sound/hda/intel-nhlt.c)
Date: Thu, 29 Aug 2019 17:08:21 +0200	[thread overview]
Message-ID: <s5hzhjs102i.wl-tiwai@suse.de> (raw)
In-Reply-To: <19edfb9a-f7b3-7a89-db5a-33289559aeef@linux.intel.com>

On Thu, 29 Aug 2019 00:45:05 +0200,
Pierre-Louis Bossart wrote:
> 
> 
> >>> I just checked with Mark Brown's for-next tree
> >>> 8aceffa09b4b9867153bfe0ff6f40517240cee12
> >>> and things are fine in i386 mode, see below.
> >>>
> >>> next-20190828 also works fine for me in i386 mode.
> >>>
> >>> if you can point me to a tree and configuration that don't work
> >>> I'll look into this, I'd need more info to progress.
> >>
> >> Please try the attached randconfig file.
> >>
> >> Thanks for looking.
> >
> > Ack, I see some errors as well with this config. Likely a missing
> > dependency somewhere, working on this now.
> 
> My bad, I added a fallback with static inline functions in the .h file
> when ACPI is not defined, but the .c file was still compiled.
> 
> The diff below makes next-20190828 compile with Randy's config.

IMO, we need to fix the site that enables this config.  i.e.
the "select SND_INTEL_NHLT" must be always conditional, e.g.
	select SND_INTEL_NHLT if ACPI

> It looks like the alsa-devel server is down btw?

Now it seems starting again.


thanks,

Takashi

> diff --git a/sound/hda/Makefile b/sound/hda/Makefile
> index 8560f6ef1b19..b3af071ce06b 100644
> --- a/sound/hda/Makefile
> +++ b/sound/hda/Makefile
> @@ -14,5 +14,7 @@ obj-$(CONFIG_SND_HDA_CORE) += snd-hda-core.o
>  #extended hda
>  obj-$(CONFIG_SND_HDA_EXT_CORE) += ext/
> 
> +ifdef CONFIG_ACPI
>  snd-intel-nhlt-objs := intel-nhlt.o
>  obj-$(CONFIG_SND_INTEL_NHLT) += snd-intel-nhlt.o
> +endif
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 


  parent reply	other threads:[~2019-08-29 15:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28  3:40 mmotm 2019-08-27-20-39 uploaded akpm
2019-08-28 16:58 ` mmotm 2019-08-27-20-39 uploaded (objtool: xen) Randy Dunlap
2019-08-28 17:19   ` Josh Poimboeuf
2019-08-28 17:56     ` Randy Dunlap
2019-08-28 20:01       ` Josh Poimboeuf
2019-08-29  8:24         ` Peter Zijlstra
2019-08-29 23:37           ` Josh Poimboeuf
2019-08-30  4:10             ` Sedat Dilek
2019-08-30  4:10               ` Sedat Dilek
2019-09-02 12:34           ` [tip: x86/urgent] x86/uaccess: Don't leak the AC flags into __get_user() argument evaluation tip-bot2 for Peter Zijlstra
2019-08-28 17:59 ` mmotm 2019-08-27-20-39 uploaded (gpu/drm/amd/display/) Randy Dunlap
2019-08-28 18:53   ` Alex Deucher
2019-08-28 18:53     ` Alex Deucher
2019-08-28 18:30 ` mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c) Randy Dunlap
2019-08-28 19:28   ` Pierre-Louis Bossart
2019-08-28 21:06     ` Randy Dunlap
2019-08-28 22:20       ` Pierre-Louis Bossart
2019-08-28 22:45         ` Pierre-Louis Bossart
2019-08-28 22:59           ` Randy Dunlap
2019-08-29  2:26             ` Randy Dunlap
2019-08-29 15:08           ` Takashi Iwai [this message]
2019-08-29 15:08             ` [alsa-devel] " Takashi Iwai
2019-08-29 16:22             ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hzhjs102i.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=mm-commits@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.