Re: [PATCH v3 05/13] ALSA: hda: check stream decoupled register state

[Takashi Iwai <tiwai@suse.de>]

On Fri, 16 Dec 2016 09:34:51 +0100,
Jeeja KP wrote:
> 
> On Thu, Dec 08, 2016 at 01:41:16PM +0530, jeeja.kp@intel.com wrote:
> > From: Jeeja KP <jeeja.kp@intel.com>
> Hi Takashi,
> 
> I have fixed the comments on the V2 patch.
> Can you please ACK this patch of this series if there no concern, as this on
> on sound/hda/. I think Mark is waiting on that.. 

Looks good to me.
  Acked-by: Takashi Iwai <tiwai@suse.de>

thanks,

Takashi

> 
> > 
> > Check stream decoupled register value with requested value
> > before decoupling/coupling the stream.
> > 
> > Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
> > ---
> >  sound/hda/ext/hdac_ext_stream.c | 15 +++++++++------
> >  1 file changed, 9 insertions(+), 6 deletions(-)
> > 
> > diff --git a/sound/hda/ext/hdac_ext_stream.c b/sound/hda/ext/hdac_ext_stream.c
> > index 3be051a..c96d7a7 100644
> > --- a/sound/hda/ext/hdac_ext_stream.c
> > +++ b/sound/hda/ext/hdac_ext_stream.c
> > @@ -128,14 +128,17 @@ void snd_hdac_ext_stream_decouple(struct hdac_ext_bus *ebus,
> >  {
> >  	struct hdac_stream *hstream = &stream->hstream;
> >  	struct hdac_bus *bus = &ebus->bus;
> > +	u32 val;
> > +	int mask = AZX_PPCTL_PROCEN(hstream->index);
> >  
> >  	spin_lock_irq(&bus->reg_lock);
> > -	if (decouple)
> > -		snd_hdac_updatel(bus->ppcap, AZX_REG_PP_PPCTL, 0,
> > -				AZX_PPCTL_PROCEN(hstream->index));
> > -	else
> > -		snd_hdac_updatel(bus->ppcap, AZX_REG_PP_PPCTL,
> > -					AZX_PPCTL_PROCEN(hstream->index), 0);
> > +	val = readw(bus->ppcap + AZX_REG_PP_PPCTL) & mask;
> > +
> > +	if (decouple && !val)
> > +		snd_hdac_updatel(bus->ppcap, AZX_REG_PP_PPCTL, mask, mask);
> > +	else if (!decouple && val)
> > +		snd_hdac_updatel(bus->ppcap, AZX_REG_PP_PPCTL, mask, 0);
> > +
> >  	stream->decoupled = decouple;
> >  	spin_unlock_irq(&bus->reg_lock);
> >  }
> > -- 
> > 2.5.0
> > 
> 
> -- 
>