Re: [PATCH 0/7] Add support for Legacy HDMI audio drivers

[Takashi Iwai <tiwai@suse.de>]

On Mon, 12 Dec 2016 19:10:36 +0100,
Jerome Anand wrote:
> 
> Legacy (CherryTrail/ Baytrail) HDMI audio drivers added
> 
> Legacy hdmi audio-Gfx interaction/ interfacing is updated to use
> irq chip framework
> 
> Jerome Anand (7):
>   drm/i915: setup bridge for HDMI LPE audio driver
>   drm/i915: Add support for audio driver notifications
>   ALSA: add shell for Intel HDMI LPE audio driver
>   ALSA: x86: hdmi: Add audio support for BYT and CHT
>   ALSA: x86: hdmi: Improve position reporting
>   ALSA: x86: hdmi: Fixup some monitor
>   ALSA: x86: hdmi: continue playback even when display  resolution
>     changes

I guess this patchset should go better through sound git tree, so I'd
need ACKs for i915 changes in anyway.

Can i951 guys review these please?

Setting up the platform device and irqchip looks simple enough, so I'm
OK if i915 people think it being acceptable -- although it's a bit
unfortunate that we would have two distinct interfaces between video
and audio.

There are a few minor issues in some codes, and I'll comment in each
patch.


thanks,

Takashi

> 
>  Documentation/gpu/i915.rst             |    9 +
>  drivers/gpu/drm/i915/Makefile          |    3 +
>  drivers/gpu/drm/i915/i915_drv.c        |    8 +-
>  drivers/gpu/drm/i915/i915_drv.h        |   18 +
>  drivers/gpu/drm/i915/i915_irq.c        |   27 +
>  drivers/gpu/drm/i915/i915_reg.h        |    3 +
>  drivers/gpu/drm/i915/intel_audio.c     |    8 +
>  drivers/gpu/drm/i915/intel_hdmi.c      |    1 +
>  drivers/gpu/drm/i915/intel_lpe_audio.c |  409 +++++++
>  include/drm/intel_lpe_audio.h          |   46 +
>  sound/Kconfig                          |    2 +
>  sound/Makefile                         |    2 +-
>  sound/x86/Kconfig                      |   16 +
>  sound/x86/Makefile                     |   10 +
>  sound/x86/intel_hdmi_audio.c           | 1932 ++++++++++++++++++++++++++++++++
>  sound/x86/intel_hdmi_audio.h           |  201 ++++
>  sound/x86/intel_hdmi_audio_if.c        |  551 +++++++++
>  sound/x86/intel_hdmi_lpe_audio.c       |  626 +++++++++++
>  sound/x86/intel_hdmi_lpe_audio.h       |  692 ++++++++++++
>  19 files changed, 4561 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/intel_lpe_audio.c
>  create mode 100644 include/drm/intel_lpe_audio.h
>  create mode 100644 sound/x86/Kconfig
>  create mode 100644 sound/x86/Makefile
>  create mode 100644 sound/x86/intel_hdmi_audio.c
>  create mode 100644 sound/x86/intel_hdmi_audio.h
>  create mode 100644 sound/x86/intel_hdmi_audio_if.c
>  create mode 100644 sound/x86/intel_hdmi_lpe_audio.c
>  create mode 100644 sound/x86/intel_hdmi_lpe_audio.h
> 
> -- 
> 2.9.3
> 
> base-commit: f6a248e2507f98d7eb1f4fec8cfcbf685a33d289
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx