From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754377Ab3HHFni (ORCPT ); Thu, 8 Aug 2013 01:43:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56612 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355Ab3HHFnh (ORCPT ); Thu, 8 Aug 2013 01:43:37 -0400 Date: Thu, 08 Aug 2013 07:45:05 +0200 Message-ID: From: Takashi Iwai To: Mark Brown Cc: "Felipe F. Tonello" , alsa-devel@alsa-project.org, Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] ALSA: Added jack detection KControl support In-Reply-To: <20130807164509.GO6427@sirena.org.uk> References: <1375430365-13232-1-git-send-email-eu@felipetonello.com> <1375430365-13232-2-git-send-email-eu@felipetonello.com> <20130807164509.GO6427@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 7 Aug 2013 17:45:09 +0100, Mark Brown wrote: > > On Fri, Aug 02, 2013 at 12:59:24AM -0700, Felipe F. Tonello wrote: > > > +int jack_ctl_integer_info(struct snd_kcontrol *kcontrol, > > + struct snd_ctl_elem_info *uinfo) > > +{ > > + uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; > > + uinfo->count = 0x10000U; > > + uinfo->value.integer.min = 0; > > + uinfo->value.integer.max = 0xffff; > > + return 0; > > +} > > I'd expected to see us creating multiple boolean controls here. I don't > have a great problem with doing things this way but it's surprising and > I worry about confusing existing userspace, Takashi? Yes, multiple boolean would make more sense. thanks, Takashi