From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754508AbZJBJCz (ORCPT ); Fri, 2 Oct 2009 05:02:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753087AbZJBJCy (ORCPT ); Fri, 2 Oct 2009 05:02:54 -0400 Received: from cantor.suse.de ([195.135.220.2]:59423 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752608AbZJBJCx (ORCPT ); Fri, 2 Oct 2009 05:02:53 -0400 Date: Fri, 02 Oct 2009 11:02:56 +0200 Message-ID: From: Takashi Iwai To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: linux-kernel@vger.kernel.org, Sam Ravnborg , Andrew Morton , Jaroslav Kysela , alsa-devel@alsa-project.org Subject: Re: [PATCH 06/34] don't use __devexit_p to wrap hal2_remove In-Reply-To: <20091001085355.GD2181@pengutronix.de> References: <20091001082607.GA2181@pengutronix.de> <1254385718-14254-6-git-send-email-u.kleine-koenig@pengutronix.de> <20091001085355.GD2181@pengutronix.de> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 1 Oct 2009 10:53:55 +0200, Uwe Kleine-König wrote: > > On Thu, Oct 01, 2009 at 10:36:59AM +0200, Takashi Iwai wrote: > > At Thu, 1 Oct 2009 10:28:10 +0200, > > Uwe Kleine-König wrote: > > > > > > The function hal2_remove is defined using __exit, so don't use __devexit_p > > > but __exit_p to wrap it. > > > > I think it's the other way round. We should replace __exit with __devexit. > > Ditto for sound/mips/sgio2audio.c. > Actually both ways are possible. I choosed the alternative that doesn't > add bloat to the kernel. The cost is that the device isn't hotplugable, > but you can still unload the module to unbind the driver. Hm, is it really safe to set remove=NULL although the driver needs some work at unbinding? It looks like that unbind is allowed no matter whether remove is NULL or not. So, it would jus keeps stray resources, and it might conflict at the next bind. > I don't care much, but prefer slightly my approach as changing the patch > is work for me :-) I prefer rather symmetry and safety :) I'm going to change to __devexit. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 06/34] don't use __devexit_p to wrap hal2_remove Date: Fri, 02 Oct 2009 11:02:56 +0200 Message-ID: References: <20091001082607.GA2181@pengutronix.de> <1254385718-14254-6-git-send-email-u.kleine-koenig@pengutronix.de> <20091001085355.GD2181@pengutronix.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 5295E103956 for ; Fri, 2 Oct 2009 11:02:57 +0200 (CEST) In-Reply-To: <20091001085355.GD2181@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Andrew Morton , Sam Ravnborg , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org QXQgVGh1LCAxIE9jdCAyMDA5IDEwOjUzOjU1ICswMjAwLApVd2UgS2xlaW5lLUvDtm5pZyB3cm90 ZToKPiAKPiBPbiBUaHUsIE9jdCAwMSwgMjAwOSBhdCAxMDozNjo1OUFNICswMjAwLCBUYWthc2hp IEl3YWkgd3JvdGU6Cj4gPiBBdCBUaHUsICAxIE9jdCAyMDA5IDEwOjI4OjEwICswMjAwLAo+ID4g VXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cj4gPiA+IAo+ID4gPiBUaGUgZnVuY3Rpb24gaGFsMl9y ZW1vdmUgaXMgZGVmaW5lZCB1c2luZyBfX2V4aXQsIHNvIGRvbid0IHVzZSBfX2RldmV4aXRfcAo+ ID4gPiBidXQgX19leGl0X3AgdG8gd3JhcCBpdC4KPiA+IAo+ID4gSSB0aGluayBpdCdzIHRoZSBv dGhlciB3YXkgcm91bmQuICBXZSBzaG91bGQgcmVwbGFjZSBfX2V4aXQgd2l0aCBfX2RldmV4aXQu Cj4gPiBEaXR0byBmb3Igc291bmQvbWlwcy9zZ2lvMmF1ZGlvLmMuCj4gQWN0dWFsbHkgYm90aCB3 YXlzIGFyZSBwb3NzaWJsZS4gIEkgY2hvb3NlZCB0aGUgYWx0ZXJuYXRpdmUgdGhhdCBkb2Vzbid0 Cj4gYWRkIGJsb2F0IHRvIHRoZSBrZXJuZWwuICBUaGUgY29zdCBpcyB0aGF0IHRoZSBkZXZpY2Ug aXNuJ3QgaG90cGx1Z2FibGUsCj4gYnV0IHlvdSBjYW4gc3RpbGwgdW5sb2FkIHRoZSBtb2R1bGUg dG8gdW5iaW5kIHRoZSBkcml2ZXIuCgpIbSwgaXMgaXQgcmVhbGx5IHNhZmUgdG8gc2V0IHJlbW92 ZT1OVUxMIGFsdGhvdWdoIHRoZSBkcml2ZXIgbmVlZHMKc29tZSB3b3JrIGF0IHVuYmluZGluZz8g IEl0IGxvb2tzIGxpa2UgdGhhdCB1bmJpbmQgaXMgYWxsb3dlZCBubwptYXR0ZXIgd2hldGhlciBy ZW1vdmUgaXMgTlVMTCBvciBub3QuICBTbywgaXQgd291bGQganVzIGtlZXBzIHN0cmF5CnJlc291 cmNlcywgYW5kIGl0IG1pZ2h0IGNvbmZsaWN0IGF0IHRoZSBuZXh0IGJpbmQuCgo+IEkgZG9uJ3Qg Y2FyZSBtdWNoLCBidXQgcHJlZmVyIHNsaWdodGx5IG15IGFwcHJvYWNoIGFzIGNoYW5naW5nIHRo ZSBwYXRjaAo+IGlzIHdvcmsgZm9yIG1lIDotKQoKSSBwcmVmZXIgcmF0aGVyIHN5bW1ldHJ5IGFu ZCBzYWZldHkgOikKSSdtIGdvaW5nIHRvIGNoYW5nZSB0byBfX2RldmV4aXQuCgoKdGhhbmtzLAoK VGFrYXNoaQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpB bHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDov L21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK